Giter VIP home page Giter VIP logo

Comments (6)

shilman avatar shilman commented on May 27, 2024 2

Ok, I fixed the release flow and published 7.0.9. Unfortunately the GH release for 7.0.9 contains all the changes from 7.0.4 to 7.0.9, which is annoying. But moving forward the new releases/changelogs should be correct.

from addon-designs.

pocka avatar pocka commented on May 27, 2024 1

https://github.com/storybookjs/addon-designs/blob/369a8897c3204a005ba6e9a4e160a27f3cff4668/packages/storybook-addon-designs/CHANGELOG.md

It seems the CHANGELOG is now recorded in there and the one at the root no longer gets updated. Release page on GitHub repository is getting updates too. I guess the change was introduced in #198.

@shilman
We should mark the old CHANGELOG as obsolete. Renaming to something like CHANGELOG.v1-6.md would be good?
Also I believe the up-to-date CHANGELOG file should be at repository root for better discoverability, could you configure the release script to emit the file at the repo root?

from addon-designs.

shilman avatar shilman commented on May 27, 2024

@pocka thanks for the heads up. I agree with your proposal, let me see what we can do!

from addon-designs.

Hinton avatar Hinton commented on May 27, 2024

Thanks for the updates @pocka and @shilman. The latest version published on npm is 7.0.7, https://www.npmjs.com/package/@storybook/addon-designs, while github releases still marks 7.0.4 as the latest release, which is also the latest git tag. The changelog at https://github.com/storybookjs/addon-designs/blob/master/packages/storybook-addon-designs/CHANGELOG.md stops at 7.0.1.

from addon-designs.

pocka avatar pocka commented on May 27, 2024

The latest version published on npm is 7.0.7, https://www.npmjs.com/package/@storybook/addon-designs, while github releases still marks 7.0.4 as the latest release, which is also the latest git tag. The changelog at https://github.com/storybookjs/addon-designs/blob/master/packages/storybook-addon-designs/CHANGELOG.md stops at 7.0.1.

@shilman Do you have any idea on this version mismatch? Tooling issue?
Having npm versions not existing on source control (tags) could sound suspicious to users...

from addon-designs.

shilman avatar shilman commented on May 27, 2024

@pocka it looks like merges to master are causing releases to be published but for some reason unable to write back to github due to a permissions issue. you can see it in the log here:

https://github.com/storybookjs/addon-designs/actions/runs/7059456877/job/19217051455

I'll look into what's going wrong this week.

from addon-designs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.