Giter VIP home page Giter VIP logo

Comments (5)

Beakerboy avatar Beakerboy commented on May 17, 2024 4

I would love to work with you on this issue. I have some custom three-js geometries that render a few different roof shapes given their outlines:

https://github.com/Beakerboy/Threejs-Geometries

A hipped roof is next on my list. I’ll review your straight skeleton implementation and see what I can figure out.

from streets-gl.

StrandedKitty avatar StrandedKitty commented on May 17, 2024 2

I've switched to a much more robust CGAL straight skeleton implementation that works much better with complex OSM polygons.
See updated https://github.com/StrandedKitty/straight-skeleton for details.

from streets-gl.

StrandedKitty avatar StrandedKitty commented on May 17, 2024

@Beakerboy Good luck! My hipped roof implementation is located in HippedRoofBuilder.ts, you can take a look at it. Overall, there's nothing complicated, it's pretty easy to render a hipped roof once you have a straight skeleton generated.

from streets-gl.

kayD avatar kayD commented on May 17, 2024

Just for adding another example: https://streets.gl/#53.55148,10.00444,45.00,0.00,473.43

from streets-gl.

kayD avatar kayD commented on May 17, 2024

Works really well for most situations, nice overall improvement!
Example: https://streets.gl/#49.79288,9.93804,45.00,119.17,387.58

Thank you for that elaborate fix.

from streets-gl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.