Giter VIP home page Giter VIP logo

Comments (3)

patrick91 avatar patrick91 commented on June 8, 2024 1

Now... I was wrong... Definitely!

BUT... Is that really the proper error message to log in this case?
It -rather- seems like it crashes badly due to some bug while trying to deal with this bad behavior.

Probably, it should check if self._handler is actually instantiated before using it or -better- it shouldn't call disconnect before actually connecting.

Yeah, that's clearly a bug 😊 I'd be happy to review a PR, or if you have a test/minimal reproduction I can attempt a bug fix/workaround :)

In the future, I would prefer not to receive an unclear (and apparently serious) Sentry notification every time a bot tries to open a WebSocket connection with my server... 😉

Well it wasn't intentional :P

from strawberry.

Byloth avatar Byloth commented on June 8, 2024

... also thanks for the priceless and fundamental help this user gave me! 🤣

image

from strawberry.

Byloth avatar Byloth commented on June 8, 2024

Well it wasn't intentional :P

Of course... I know! ❤️

Please, don't get me wrong; I probably wasn't able to convey the tone of my comment correctly.
It didn't mean to be aggressive or accusatory at all! 🥹


I'd be happy to review a PR, or if you have a test/minimal reproduction I can attempt a bug fix/workaround :)

It should happen on every single app that uses Django + Strawberry + Channels... It has to.
But, yes! I would be happy to contribute! 🙃

from strawberry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.