Giter VIP home page Giter VIP logo

Comments (7)

G-Rath avatar G-Rath commented on June 7, 2024 1

I'd be happy to accept PRs moving us off json-joy

from memfs.

thatsmydoing avatar thatsmydoing commented on June 7, 2024

I did make a branch for this but realized that the problem here (and with json-joy) is that they're doing too much. It seems like this package should be split up into a core memfs just for node and separate packages for the experimental FSA adapters (since only those use the extra dependencies).

I realize that's a big ask so I understand if that's out of scope of the project.

from memfs.

G-Rath avatar G-Rath commented on June 7, 2024

@thatsmydoing I don't disagree but that's also a much bigger piece of work and not strictly my call alone to make.

In the meantime though do you think it might be possible to move off json-joy?

from memfs.

G-Rath avatar G-Rath commented on June 7, 2024

alternatively, we could try to make json-joy an optional peer dependency 🤔

from memfs.

G-Rath avatar G-Rath commented on June 7, 2024

@thatsmydoing I'm just released v4.8.0-next.1 which makes both dependencies optional

derp nope ok we need this for core

from memfs.

thatsmydoing avatar thatsmydoing commented on June 7, 2024

Oh, sorry just got back to this. Thanks for doing this. Which part of core memfs used json-joy?

from memfs.

G-Rath avatar G-Rath commented on June 7, 2024

src/print/index.ts iirc

from memfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.