Comments (9)
Well, then we should remove that and point users towards Discussions for questions and comments.
from stride.
Sorry,my english is not good ,but the word ‘like’ is ‘as sth be sth’ , In short,I understand your mean。
if i use Span replace old code to reduce GC,Is that okay? or use other High level C# Feature to improve Performance or ReFactory Code to reduce code line num?Is that okay?
from stride.
if i use Span replace old code to reduce GC,Is that okay? or use other High level C# Feature to improve Performance
Yep, very much welcome
ReFactory Code to reduce code line num?Is that okay?
Just reducing the amount of lines, not really, but if you reduce the amount of lines while fixing a bug or while improving performance, yes.
from stride.
Condider closing this thread @Arc-huangjingtong ?
from stride.
I didn't notice this was an issue. Why are there issues labeled as question
if we have the Discussions tab in GitHub?
from stride.
Not exactly sure I understand the question.
I'm guessing you meant;
if (fun != null)
{
fun.Invoke();
}
For the first snippet.
If this question is about whether we would accept PRs which only contain code style changes, like you've shown above, not really ... we would rather your PR introduce at least a new feature, improve performance or fix a bug, if that's the case you may introduce change in style if they don't go against the style of the rest of the code base.
Reviewing style changes is very time consuming and if the PR doesn't do anything besides that it's often not worth the effort.
Let me know if I misinterpreted the question !
from stride.
Thank You!
from stride.
from stride.
Probably it was there historically. We can easily convert any issue to a discussion. Also, I can change that button to behave like the below, just links, so it could be just a link to Discussion.
from stride.
Related Issues (20)
- Nagivation doesnt work with static meshes HOT 10
- An error occurred while updating the launche
- Stride doesn't start HOT 7
- [GameStudio] Investigate Quantum issue handled in PR #2307
- can't find MSBuild HOT 60
- Fbx not displaying correctly with associated errors in VS HOT 9
- Empty classes break the editor instantiation dropdown HOT 2
- Effect Compiler/User Settings missing in Project property grid in the editor
- Android 13+ Bluetooth permission error
- Android 14+ RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED error HOT 2
- Editor bug import asset warning bug within the game project HOT 1
- Pack target crashes
- Error when assets in different projects with the same relative path
- Grayscale textures are broken in 4.2.0.2188 HOT 9
- When importing multiple assets, copy all assets to resources folder, rather than checking each asset on import.
- A piece of code, I want to know his inner workings
- Shader Key Files not being generated due to System.IO.IOException: Pipe is broken
- Stride Prefab Selecting from array not working HOT 2
- UI page with multiple buttons cause error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stride.