Giter VIP home page Giter VIP logo

Comments (5)

cthtrifork avatar cthtrifork commented on June 12, 2024

There is a lot of operators which support additionalVolumes. I would probably do something similar to OpenSearch:
https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/charts/opensearch-cluster/templates/opensearch-cluster-cr.yaml#L69 if accepted.

from strimzi-kafka-operator.

scholzj avatar scholzj commented on June 12, 2024

This should be closed as a duplicate of #3693.

In general, this requires a proposal (https://github.com/strimzi/proposals). If you are interested in contributing this feature, that would be welcome - writing the proposal would be the first step. I think the preferred solution from the Strimzi side is to use the existing Pod and Container templates and configure the additional volumes / volume mount points there.

from strimzi-kafka-operator.

cthtrifork avatar cthtrifork commented on June 12, 2024

@scholzj I don't mind closing this. I also agree on adding to the existing pod and container templates, but do you want a proposal before i prepare a PR?

from strimzi-kafka-operator.

scholzj avatar scholzj commented on June 12, 2024

Yes, this is a major enhancement with API impact. So this should have a proposal written and approved first.

Of course, if you want to write a prototype implementation to accompany the proposal (to for example make sure it is feasible or when you want to run the Strimzi system tests), it is fine to have a Draft PR for it and we can for example run the System Tests on it. But it will not be merged/fully reviewed before the proposal is approved (and having the prototype PR does not guarantee in any way that the proposal will be accepted of course).

(But just to be clear, you are not required to have any kind of prototype implementation to open the proposal. From my own experience, sometimes it helps to write the proposal as you better understand what is needed. But for other proposals it is not really much helpful. So it depends a lot.)

from strimzi-kafka-operator.

cthtrifork avatar cthtrifork commented on June 12, 2024

Thanks for the feedback. I will close this and work on a proposal + a draft PR.

from strimzi-kafka-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.