Giter VIP home page Giter VIP logo

Comments (22)

jasongrishkoff avatar jasongrishkoff commented on August 24, 2024 16

Looks like it's solved with this pull request: https://github.com/studiointeract/accounts-ui/pull/138/files

If you need it now, you can create a directory called "packages" in your meteor app. Then you'll git clone this repo, edit the packages.json to change version to 1.3.2, and edit your .meteor/packages to reflect @1.3.2 as the version for this package. You can then edit the file as shown in that pull request, and bam! It'll work <3

from accounts-ui.

yanickrochon avatar yanickrochon commented on August 24, 2024 6

Meteor 1.7 was released, still no update on this?

from accounts-ui.

tab00 avatar tab00 commented on August 24, 2024 5

Can that pull request just be merged into master?

from accounts-ui.

hitch90 avatar hitch90 commented on August 24, 2024 2

I have this same error while using react-router.

from accounts-ui.

silkroadnomad avatar silkroadnomad commented on August 24, 2024 2

I cloned a forked repo which seems to work or doesn't throw an error right now https://github.com/idmadj/accounts-ui.git

from accounts-ui.

silkroadnomad avatar silkroadnomad commented on August 24, 2024 2

@tab00 no. I was forking it by myself and just added a couple changes. I might should make a pull request back to the project.

See my changes: Doichain@8cf24a1
(I don't know the actual progress of this issue here, why nobody fixes it or if its fixed somewhere else now)

What you have to do in order to use it:

  1. make a folder 'packages' in your meteor project directory
  2. cd packages git clone https://github.com/Doichain/accounts-ui.git
  3. meteor should reload the package.

Let me know if it works for you.
P.S. I was adapting a accounts-material-ui on top of it in case you like to try it: Works the same way - just put it into packages: https://github.com/Doichain/accounts-material.git

from accounts-ui.

yanickrochon avatar yanickrochon commented on August 24, 2024 1

@inspiraluna the package accounts-ui requires react-tap-event-plugin, however once installed, it throws "Cannot read property 'injection' of undefined".

I believe others have removed this dependency successfully, and this should get updated.

Also, Material UI is at version 3.1.1 while your module depends on 0.16.x. It's about time to upgrade 😝

from accounts-ui.

lc3t35 avatar lc3t35 commented on August 24, 2024 1

Hi @inspiraluna , [email protected] (meteor 1.8 too), I'm trying https://github.com/royGil/accounts-react now ...

from accounts-ui.

JonathanLehner avatar JonathanLehner commented on August 24, 2024 1

how about we decide to continue with https://github.com/idmadj/accounts-ui.git then?

it seems to work.

from accounts-ui.

jasongrishkoff avatar jasongrishkoff commented on August 24, 2024

Ditto, same error.

Warning: Functions are not valid as a React child. This may happen if you return a Component instead of <Component /> from render. Or maybe you meant to call this function rather than return it.

from accounts-ui.

jmarceli avatar jmarceli commented on August 24, 2024

Thanks @jasongrishkoff
In your "instruction" there is one mistake (I think), version change should be done inside packages/accounts-ui/package.js file not packages/accounts-ui/packages.json.

from accounts-ui.

yanickrochon avatar yanickrochon commented on August 24, 2024

Who are the maintainers of this repository? Is this project dead?

from accounts-ui.

kwunyeung avatar kwunyeung commented on August 24, 2024

Very strange, even my PR #135 fixed this, the maintainer closed it without merging it. Only the createContainer was replace with withTracker.

from accounts-ui.

ratcliffej avatar ratcliffej commented on August 24, 2024

+1 for this problem too. Many thanks for your patch @jasongrishkoff!

from accounts-ui.

tab00 avatar tab00 commented on August 24, 2024

@inspiraluna, is it an atmosphere package (that we can install by meteor add)?

from accounts-ui.

lc3t35 avatar lc3t35 commented on August 24, 2024

Facing the same issue, no updates since months, if this repo is no more maintained, please state it clearly in the README so we don't waste time to install it. Thank you.

from accounts-ui.

silkroadnomad avatar silkroadnomad commented on August 24, 2024

Hello @lc3t35 , it's interesting because last night I was updating my meteor 1.8 (with react 15.x to react 16.6.3. I also had this problem. So I removed react-tap-event-plugin to work with react 16.6.3.
See: https://github.com/Doichain/accounts-ui/releases/tag/release-1.2.24
Do you use react 16.x? I am not yet a react professional, since I mostly do other things durring the day. So I'd be very happy to get some comments or recommendations on that. Thanks @yanickrochon btw. on your hints which I overread as it seems.

from accounts-ui.

silkroadnomad avatar silkroadnomad commented on August 24, 2024

makes sense. Let us know here how it was going maybe I'd like to switch too!

from accounts-ui.

silkroadnomad avatar silkroadnomad commented on August 24, 2024

@lc3t35 which styling do you use? I am porting to material ui now.

from accounts-ui.

silkroadnomad avatar silkroadnomad commented on August 24, 2024

@JonathanLehner seems to use react 15 - in case you want to be up to date with react 16 the whole router 4 situation needs to be changed in this package. https://github.com/royGil/accounts-react uses the new react router 4.

from accounts-ui.

JonathanLehner avatar JonathanLehner commented on August 24, 2024

from accounts-ui.

derwaldgeist avatar derwaldgeist commented on August 24, 2024

Please clearly mark this package as being deprecated. It's a waste of time installing it if such a basic error pops up und no fixes have been provided since over a year. Thanks.

from accounts-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.