Comments (4)
I would also argue to remove the 'Menu' text to reduce the width, most websites seem to be using the hamburger button on its own anyway.
I'm not an expert but I do caution against making such an assumption for accessibility purposes. It is certainly possible that a significant portion of users (if not all of them) understand what a hamburger menu is for.
Perhaps a Customizer checkbox option that would allow the appropriate decision-makers to disable/enable the menu text feature based on accessibility compliance guidelines and user feedback?
It would be a similar feature that I would like to see for disabling/enabling the sticky header, again for the same reason previously mentioned.
from genesis-sample.
I would agree with this, such a small item takes up a lot of real estate on a mobile, significantly reducing the amount of content above the fold. I would also argue to remove the 'Menu' text to reduce the width, most websites seem to be using the hamburger button on it's own anyway.
from genesis-sample.
wordpress.org uses hamburger button only, but not sure whether it is accessible, will take a closer look.
from genesis-sample.
The wordpress.org mobile-menu-button element includes
<button id="mobile-menu-button" aria-expanded="false"><span class="screen-reader-text">Toggle Menu</span></button>
The text is hidden visually using the screen-reader-class, however the Genesis Sample menu-toggle element includes:
<button class="menu-toggle dashicons-before dashicons-menu" aria-expanded="false" aria-pressed="false" id="genesis-mobile-nav-primary">Menu</button>
without the screen-reader-text class.
There maybe other considerations for accessibility but that's the only obvious one I could find looking briefly at wordpress.org.
from genesis-sample.
Related Issues (20)
- .first-block-align-wide body class not showing with media-text block. HOT 3
- the woocommerce body_class() issues in my wesbite HOT 3
- category archive does not work HOT 1
- white space HOT 4
- Cover block alignwide pushes beyond site width on iPad Pro HOT 2
- Remove Genesis Simple FAQ CSS
- Body classes for "first" blocks are super helpful, and "last" block classes could be helpful too. HOT 2
- Add sub pages and sub menu
- Release: Version 3.3.1
- Composer errors
- Release: Version 3.4.1
- 20px editor-font-sizes overridden after 5.9 update HOT 4
- Add Block Patterns HOT 1
- Release: Version 3.4.2
- Host Sample Theme on WordPress.org
- CSS contains incorrect font specifications
- drop down menu not aligned properly
- Modern CSS
- Author Box Title – Change H4 to H2 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from genesis-sample.