Comments (3)
Also, if this were done, it could also mean that SSHy would be able to work with an out-of-the-box wsproxy instead of requiring the patched one supplied with SSHy. That would be a big bonus.
I notice that upstream wsproxy has now pinned the version of ws to 2.x, which means it doesn't need the patch in stuicey/wsProxy@8ef26ac (although it still might be a good idea to submit this upstream so it can move to ws 3.x)
from sshy.
Yeah, its trivial to update this for use with websockify (see here), I'd be hesitant to make it part of the normal release though unless websockify or another major websocket proxy supports multiplexing? If theres a better suited alternative I don't see the harm in switching, all wsproxy does is bridge ws <-> tcp sockets.
wsproxy was developed for use with Ragnarök Online, so I wouldn't be surprised if they want to stay at ws 2.x to maintain compatability.
from sshy.
Is ws (library) >= 3.x required for multiplexing then?
I don't know much about websockets, but as far as I can tell, the benefit from multiplexing is if you have lots of tabs open with ssh sessions, all going to the same backend server. Is that correct?
ISTM that binary websockets would be more widely compatible. You can still release an optimised version of wsproxy, using a newer version of ws library, but it would be optional.
Given that wsproxy is barely maintained it's probably worth forking wsproxy with a different name, so it's available via a simple npm i
.
from sshy.
Related Issues (20)
- Question and Possible bug. HOT 4
- Question: SSHy as angular/vue component?
- Keeps loading without connecting - wsproxy problem HOT 1
- can we have a ssh client that needs to creds
- Is there any way to include user name in wrapper.html? HOT 2
- Stuck on connecting... HOT 4
- Question: Predefined commands? HOT 2
- Better error handling
- Error connecting to Debian / OpenSSH 7.4 HOT 6
- DOMException: Failed to execute 'atob' on 'Window' HOT 1
- Unable to closure-compile or connect HOT 1
- Safari support
- Really dumb question
- Stopped working with latest browsers HOT 28
- Can't send return key in latest Chrome 90.0.4430.93 HOT 1
- Failed to execute 'atob' on 'Window'
- Latest Chrome Update broke user return HOT 2
- WebSocket connection failed: Error in connection establishment: code 1005 HOT 2
- Invalid Signature Using Public Key Auth
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sshy.