I have binary data in a string from an ajax call. If I add it to a zip file the genera

Could you try changing the code to <div class="highlight highlight-source-coffee n

corrupted zip archive when adding files with base64: false, binary: true about jszip HOT 4 CLOSED

regular commented on June 30, 2024

corrupted zip archive when adding files with base64: false, binary: true

from jszip.

Comments (4)

Stuk commented on June 30, 2024

Could you try changing the code to

                if x?.overrideMimeType
                    x.overrideMimeType 'application/zip'

and see if that helps?

from jszip.

regular commented on June 30, 2024

Hi Stuk,

as I understand it, 'text/plain; charset=x-user-defined' is the only way to keep the browser from destroying binary data that comes from an ajax call. Source: https://developer.mozilla.org/en-US/docs/DOM/XMLHttpRequest/Sending_and_Receiving_Binary_Data

And it is the only way I found that data.length is actually equal to the file size on the server. So I guess the source data is alright.

I tried what you proposed anyway. Now Chrome won't even open the link. (error message below) I guess it is because the base4 string is too short. Same with Safari.

This webpage is not available
The webpage at data:application/zip;base64,UEsDBAoAAAAAAIVGMkEAAAAAAAAAAAAAAAAHAAAAYXNzZXRzL1BLAwQKAAAAAACFRjJB+hLo/CoDAAAqAwAAEgAAAGFzc2V0cy9jZWxsXzRfaWNvb1QTkcNChoKAAAADUlIRFIAAAAQAAAAEAgGAAAAH9YQAAAARnQU1BAA9TcF0AAAAZdEVYdFNvZnR3YXJlAEFkb2JlIEltYWdlUmVhZHlxWU8AAACUlEQVQYGQ9S29VR905Vsm1JehlQU01EQ9C9Wi9Z0WF2F1GcCEiSBCd9kQ9cC9YG9Fm9SVoU20gJ0618M9X99HicJS99W1yTsmS9AH9HghmC0Nfe6eG9B0kA9R8ufjYze9bk9IQAAQ99fW0sd9f0fXRmRsAAH90hG1907Bw5kW9K0ic9AA9G1ia399X16VwAAOD90t2K9ZCglLBZE04ch9W91qc9U9X00AG9H0mU9Sn0vf9o9V5OT99WGU3zljR9Um9IyNc9Fz99xUG1218HU9T0PRsvR1+XIWyG9T9U0LP9U9S904W9C0uW9908Ty9Mg9l0wRAeSdYSkcU9UEUcxpQF0FXH9V8fUSpyCgZoX0WV24iLw9IC9JEHR9eSwa0DY99G9R9y9Dw9XQ9cC9Z0t13S5/9R9A99999Q39P99B88VpyS9JA9e9fHZm5wW9fm9Vi9UB30E9ZEIODjc99CQAAFkU+S9T9N18WT9LTYIU9B0EBg9StRd0AAHB/f69W3xVe9B9SAJQMTC1AV9XIzJRdCIBAG99H29S905IRwAJnAIE07TlCcB9QAA9X0fGR99tLQgMAB9BQAk0cW91O0kA1OT8VCz9TsiQcAU9EAAI9X0wT9jX9NS9IwAAAABJRU5EUJgVBLAwQKAAAAAACFRjJBeXXXfJ4AAACeAAAADAAAAGNvbnRlbnQuanNvbnsibm9kZV8xX2NoaWxkcmVuIjp7IjIvMSI6M30sIm5vZGVfMV9jZWxscyI6eyIxLzEiOjAsIjIvMSI6NH0sIm5vZGVfM19jZWxscyI6eyIxLzAiOjJ9LCJjZWxsXzQiOnsiaWNvbiI6Ii4vYXNzZXRzL2NlbGxfNF9pY29uIn0sImNlbGxfMiI6eyJsYWJlbCI6IkVpbiBUZXN0In19UEsBAhQACgAAAAAAhUYyQQAAAAAAAAAAAAAAAAcAAAAAAAAAAAAAAAAAAAAAAGFzc2V0cy9QSwECFAAKAAAAAACFRjJB+hLo/CoDAAAqAwAAEgAAAAAAAAAAAAAAAAAlAAAAYXNzZXRzL2NlbGxfNF9pY29uUEsBAhQACgAAAAAAhUYyQXl113yeAAAAngAAAAwAAAAAAAAAAAAAAAAAfwMAAGNvbnRlbnQuanNvblBLBQYAAAAAAwADAK8AAABHBAAAAAA= might be temporarily down or it may have moved permanently to a new web address.

from jszip.

regular commented on June 30, 2024

Ok, I solved it. Turns out that the ajax call returns garbage in the upper byte of each character. The lower bytes of the 16bit unicode character reflect the proper byte value, the upper byte often is zero but sometime is not. ANd that messes up not only JSZip but also jquery.base64 for example.

Her eis a complete test page with a loop to zero out the upper byte of each character. I keep looking for a better solution that does not require touching every byte. (or maybe you can just add a '& 0xff' somewhere to solve this.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
    <head>
        <script src="jquery.min.js"></script>
        <script src="jszip.js"></script>
    </head>
    <body></body>
    <script type="text/javascript">
      $(function() {
        var assets, url, zip;
        zip = new JSZip();
        assets = zip.folder('assets');
        url = 'http://images.apple.com/global/elements/flags/22x22/usa.png';
        $.ajax({
          url: url,
          dataType: 'text',
          beforeSend: function(x) {
            if (x != null ? x.overrideMimeType : void 0) {
              return x.overrideMimeType('text/plain; charset=x-user-defined');
            }
          },
          success: function(data) {
            var code, s2, x, zipFileLink;
            console.log("received " + data.length + " bytes");
            s2 = "";
            for (x = 0; x<data.length; ++x) {
              code = data.charCodeAt(x) & 0xff;
              s2 += String.fromCharCode(code);
            }
            data = s2;
            assets.file("test.png", data, {
              base64: false,
              binary: true
            });
            zipFileLink = "data:application/zip;base64," + zip.generate({
              base64: true,
              compression: 'STORE'
            });
            return $("body").append($("<a>").attr("href", zipFileLink).html('zip file'));
          }
        });
      });

    </script>
</html>

from jszip.

Stuk commented on June 30, 2024

This is a problem someone else has recently come across. It's a result of using strings to store binary data, and can really only be solved by moving to blobs and typed arrays (a task for another time). Doing an & 0xff internally would still require touching every byte sadly.

from jszip.

corrupted zip archive when adding files with base64: false, binary: true about jszip HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent