Giter VIP home page Giter VIP logo

Comments (8)

sapegin avatar sapegin commented on May 22, 2024

👍

from react-styleguidist.

mik01aj avatar mik01aj commented on May 22, 2024

We'll need to say that all the components are exported to global variables (https://github.com/sapegin/react-styleguidist/blob/master/src/index.js#L18) and that many components have the same name, it will cause problems (or maybe let's throw an error instead? #33)

from react-styleguidist.

sapegin avatar sapegin commented on May 22, 2024

We can throw an error and suggest to ignore the component.

from react-styleguidist.

sapegin avatar sapegin commented on May 22, 2024

I’ve added an example component that uses require(). Could you add this docs to the Readme?

from react-styleguidist.

mik01aj avatar mik01aj commented on May 22, 2024

LGTM, sorry @sapegin I didn't find time for this.

from react-styleguidist.

sapegin avatar sapegin commented on May 22, 2024

No worries ;-) I’m going to release 1.3 soon (I hope before my vacation that star), so I’m trying to add missing docs before that.

BTW, will you have time for #28 soon? I’d like to have it in 1.4.

from react-styleguidist.

mik01aj avatar mik01aj commented on May 22, 2024

This week I'm busy with other (non-react) stuff... I recommend that you just cherry-pick lovelybooks@bb024de for now.

from react-styleguidist.

sapegin avatar sapegin commented on May 22, 2024

Thanks, I already have a sticky sidebar, so I can just copypaste an actual TOC code from your commit ;-)

from react-styleguidist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.