Comments (6)
Sounds good. One question: For e.g. number-leading-zero
should the negative instead use "unexpected": "Unexpected leading zero for fractional value less than 1"??
from stylelint.
One question: For e.g. number-leading-zero should the negative instead use "unexpected": "Unexpected leading zero for fractional value less than 1"??
Yeap, I had that same thought just after I clicked "Comment"! :)
That works for me if we make the other "always"|"never" rules consistent too e.g.
declaration-colon/bang-space
: "Expected single space before "!"" and "Unexpected space before "!"declaration-block-trailing-semicolon
: "Expected a trailing semicolon" and "Unexpected trailing semicolon"number-leading-zero
: "Expected a leading zero for fractional value less than 1" and "Unexpected leading zero for fractional value less than 1"
When it comes to rules with values other than "always" and "never" I think we should tend towards "expected" over "unexpected" e.g.
url-quotes: "single"|"double"|none
We might need to create multiple rejected messages for each value if we use "unexpected" e.g.
For url-quotes: "single"
We'd need two rejected messages:
- "Unexpected double quotes for URL"
- "Unexpected lack of quotes for URL"
Where as, the "expected" approach would require just one rejected message for each value:
e.g. for url-quotes: "single"
We'd only need:
- "Expected single quotes for URL"
Sound good?
from stylelint.
Yes. I think "unexpected" (aka "rejected") is for situations where what's there is not ok but there is not a specific expected alternative. So url-quotes
never "rejects" if it's on, because it's always expecting something specific. We're in agreement.
from stylelint.
We're in agreement.
Good stuff :)
from stylelint.
👍
from stylelint.
I can do this.
from stylelint.
Related Issues (20)
- `declaration-block-no-redundant-longhand-properties` is not forwards compatible HOT 13
- `declaration-block-no-redundant-longhand-properties` needs to be value type aware HOT 8
- Add new rule to disallow specific condition in `@container` queries HOT 1
- Create option to extend rule: font-family-no-duplicate-names HOT 1
- Create option to extend rule: no-duplicate-at-import-rules HOT 1
- Create option to extend rule: no-unknown-animations HOT 1
- CLI doesn't seem to work as expected. HOT 2
- [16.4.0] Cannot suppress `selector-max-universal` HOT 4
- Add regex support to `value-no-vendor-prefix` secondary option
- Provide links to message HOT 3
- Fix `shorthand-property-no-redundant-values` false negatives for `var()` HOT 10
- Add flags/options to set custom exit codes depending on the severity HOT 10
- TypeScript reports "Type 'CosmiconfigResult' is not generic" HOT 1
- Release 16.5.0 HOT 5
- Create option to extend rule: font-family-no-duplicate-names HOT 1
- Create option to extend rule: no-duplicate-at-import-rules
- Create option to extend rule: no-unknown-animations
- Stylelint --fix does not fix two problems at the same time: the order/properties-order property, and the removal of extra empty lines. HOT 4
- no-missing-end-of-source-newline false positive after upgrade to v16.4.0 (from 15.11.0) HOT 1
- SCSS: Issue with double slash comment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stylelint.