Giter VIP home page Giter VIP logo

Comments (11)

ntwb avatar ntwb commented on May 25, 2024

Thanks for using the template @JackHowa 👍

I see you are using this config stylelint-config-sass-guidelines

What I'm unsure of thought is the custom syntax you are using:

"stylelint.customSyntax": "${workspaceFolder}/custom-syntax.js",

Is custom-syntax.js something you could share to help us debug this?

Also, does autofix work with stylelint-config-sass-guidelines when not using the stylelint.customSyntax option?

from vscode-stylelint.

JackHowa avatar JackHowa commented on May 25, 2024

Oh interesting @ntwb -- may have been a bad copy paste job re: customSyntax.

Will check-in with sass-guidelines as well in their issues

from vscode-stylelint.

JackHowa avatar JackHowa commented on May 25, 2024

customSyntax couldn't find when I looked again in my .vscode/settings.json. Must have been a bad copy paste.

Will look in sass-guidelines if they have autofix

from vscode-stylelint.

JackHowa avatar JackHowa commented on May 25, 2024

I don't know if https://marketplace.visualstudio.com/items?itemName=adamwalzer.scss-lint&ssr=false#overview will be a better fix for this. Although, there is not autofix with this extension either, although it does highlight issues

from vscode-stylelint.

ntwb avatar ntwb commented on May 25, 2024

Have you looked at https://github.com/kristerkari/stylelint-scss/?

Not all the rules but quite a few are autofixable

https://github.com/kristerkari/stylelint-scss/#list-of-rules

As stylelint-config-sass-guidelines uses stylelint-scss under the hood, I would kind of expect some those rules from the config you are using to be autofixable

from vscode-stylelint.

ota-meshi avatar ota-meshi commented on May 25, 2024

Hi @JackHowa.

Is there a "stylelint: Fix all auto-fixable Problems" command in your VS Code command palette?

image

from vscode-stylelint.

JackHowa avatar JackHowa commented on May 25, 2024

@ota-meshi yes. that is what is causing the error. The stylelint cli is working as expected

from vscode-stylelint.

JackHowa avatar JackHowa commented on May 25, 2024

@ntwb I can check that out. could that affect the vscode extension stylelint.executeAutofix not found error?

from vscode-stylelint.

ntwb avatar ntwb commented on May 25, 2024

It’s possible, some of our repo tests are testing SCSS so I expect it should work, also I would expect other SCSS users to have also noticed if this functionality wasn’t working

from vscode-stylelint.

ota-meshi avatar ota-meshi commented on May 25, 2024

Hmm... Registration of the autofix command is handled early. I can't imagine the possibility of problems before that.

https://github.com/stylelint/vscode-stylelint/blob/master/index.js#L35

from vscode-stylelint.

JackHowa avatar JackHowa commented on May 25, 2024

Working with updated settings.json. Worked better with bjankord/stylelint-config-sass-guidelines#71 (comment)

.vscode/settings.json

{
  "[scss]": {
    "editor.codeActionsOnSave": {
      "source.fixAll.stylelint": true
    },
  },
}

from vscode-stylelint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.