Giter VIP home page Giter VIP logo

Comments (10)

snebjorn avatar snebjorn commented on June 5, 2024 1

Unfortunately yes.

I found this shared browserlist config https://www.npmjs.com/package/@cleverfranke/browserslist-config
Perhaps you can test with

.browserslistrc

# You can see what browsers were selected by your queries by running:
#   npx browserslist

extends @cleverfranke/browserslist-config

from vscode-stylelint.

adalinesimonian avatar adalinesimonian commented on June 5, 2024 1

Closing as upstream bug.

from vscode-stylelint.

snebjorn avatar snebjorn commented on June 5, 2024

What can I do to move this along?

from vscode-stylelint.

adalinesimonian avatar adalinesimonian commented on June 5, 2024

Can you confirm this is still happening with the latest version of the extension? I ran a similar test where I moved a project into a subfolder on the latest version of the extension and it seemed to work, however, I wasn't using browserslist.

from vscode-stylelint.

adalinesimonian avatar adalinesimonian commented on June 5, 2024

Looks like the problem is at this line in browserslist:

var queries = require(require.resolve(name, { paths: ['.'] }))

Since the paths passed to require.resolve only reference the current working directory, since the extension is not running in the context of the subfolder but in the workspace, it can't resolve the package. You can replicate this issue in the terminal by running Stylelint from the workspace folder.

@ai I tested changing this line to

var queries = require(require.resolve(name, { paths: ['.', ctx.path] }))

and it seems to fix the problem. Am I correct to assume that this may be the right fix for this issue?

from vscode-stylelint.

ai avatar ai commented on June 5, 2024

@adalinesimonian please send PR to Browserslist.

from vscode-stylelint.

adalinesimonian avatar adalinesimonian commented on June 5, 2024

Done: browserslist/browserslist#638

from vscode-stylelint.

snebjorn avatar snebjorn commented on June 5, 2024

@adalinesimonian I'm trying to figure out how to get the newly released [email protected] updated in this extension. It appears as if it's coming from these packages:

  • @babel/helper-compilation-targets
  • caniuse-lite
  • core-js-compat

So to get it working they need to update their browserslist version and then this extension needs to use their new versions.
Is that the correct course of action? Or am I missing something :)?

from vscode-stylelint.

adalinesimonian avatar adalinesimonian commented on June 5, 2024

This extension doesn't bundle browserslist (or Stylelint); it's sourced from your project's dependencies. You'll need to update the version of browserslist in your project, after which I think you'll be good.

from vscode-stylelint.

snebjorn avatar snebjorn commented on June 5, 2024

I see, thank you

from vscode-stylelint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.