Inline images in blog post not sourced from /static but from original Ghost website about gatsby-theme-try-ghost HOT 7 CLOSED

@jpalpant Thanks a lot for the feedback and for choosing this project!

The short answer to your question is: Yes this is expected behaviour. The image insourcing is currently only done for feature images.

The reason for not having incorporated inline images yet:

1. It's more complicated compared to feature images (you first have to extract all image paths in the body text, store those paths in the GraphQL database, query and insert them in the right place, make sure the caching is still working, etc.)

2. It will prolong Gatsby build times. For small projects this is not a problem, but as build time is and issue with any Gatsby project, I expect this feature to have a large, negative impact on build times. With incremental builds emerging, maybe this is just the right time to implement this feature?!

3. I already created a package directory for this feature, but didn't get around implementing it.

I definitely support implementing such a feature (as a rehype-* plugin). I see that you have a lot of development experience. Get in contact with me, if you want to collaborate on creating this feature.

from gatsby-theme-try-ghost.

Reopened. This is a long standing enhancement that will be solved soon!

from gatsby-theme-try-ghost.

Thanks! Would love to collaborate on this if I'm able, I dropped a message via that email though I think there may be an issue with the submission, so please shoot me an email where I can reach you if it didn't go through - my email is in my GH profile.

from gatsby-theme-try-ghost.

Hey guys, just wanted to show my support for this project! I'm not a fluent developer, just a PM that is obsessed with efficiency. In my journey to build the most optimized and fast blog site I've landed here 🙂

I have tried the gatsby-plugin-ghost-images plugin which is supposed to solve for putting images within post content through the gatsby-image and sharp processors. However, I got stuck on the query and accessing it within react.

Perhaps this could be leveraged with this theme by a more skilled developer.

Again, really love this project -- I've tried a bunch of combinations of Ghost, Ghost+Cloudinary, Ghost w/ Gatsby, etc, and this one has gotten the closest to perfect performance. The last little mole to hit is optimizing all the in-content images somehow.

from gatsby-theme-try-ghost.

gatsby-plugin-ghost-images currently only sources cover/profile/feature images. not post content.

from gatsby-theme-try-ghost.

@tobimori ah thanks for the confirmation! Actually, just resolved an issue with my query and saw it was only grabbing feature_image.. oh well!

from gatsby-theme-try-ghost.

solved with PR #131

from gatsby-theme-try-ghost.