Allow arguments for commands in custom keyboard shortcuts about sumatrapdf HOT 8 CLOSED

Allow color arguments for the following commands:

        case CmdCreateAnnotText:
        case CmdCreateAnnotLink:
        case CmdCreateAnnotFreeText:
        case CmdCreateAnnotLine:
        case CmdCreateAnnotSquare:
        case CmdCreateAnnotCircle:
        case CmdCreateAnnotPolygon:
        case CmdCreateAnnotPolyLine:
        case CmdCreateAnnotHighlight:
        case CmdCreateAnnotUnderline:
        case CmdCreateAnnotSquiggly:
        case CmdCreateAnnotStrikeOut:
        case CmdCreateAnnotRedact:
        case CmdCreateAnnotStamp:
        case CmdCreateAnnotCaret:
        case CmdCreateAnnotInk:
        case CmdCreateAnnotPopup:
        case CmdCreateAnnotFileAttachment: {

from sumatrapdf.

Wow
can we have something similar for call external app 0-9 with %filename %page and %selection
to replace external viewers and more ?

from sumatrapdf.

from sumatrapdf.

Sure, show me how you would like it to work.

from sumatrapdf.

Unsure on detailed concept but currently to run the external view commands it is 3 keys
so for example we need ALT & F & A but if it was either numeric or main key board addressable 1-9 based it would be easier
some duplication might be reduced so
CTRL + C =copy to clipboard but CTRL+C reassigned to
poor example external cmd.exe programable-notepad %f %p %s allows for simpler usage of clip

from sumatrapdf.

from sumatrapdf.

I could add CmdExternalCommand e.g.

[
   Cmd = CmdExternalCommand acrobat.exe ...args
   Key = 
]
[
   Cmd = CmdExternalCommand https://translate.google.com/?op=translate&sl=auto&tl=${userlang}&text=${selection}
   Key = 
]

which could kind of subsume ExternalViewers and SelectionHandlers except they don't require a shortcut assignment so it's weird to put them in shortcuts.

A possible solution would be to add a way to define new commands, like:

Commands [
  [
    Name = CmdTranslateSelectionWithGoogle
    Cmd = CmdExternalCommand https://translate.google.com/?op=translate&sl=auto&tl=${userlang}&text=${selection}
    Type = SelectionHandler
    Key = 
  ]
]

Type would be SelectionHandler or ExternalCommand (or `ExternalViewer for compatibility with current terminology).

Key is optional because it could also be assigned via

Shortcuts [
  [
    Cmd = CmdTranslateSelectionWithGoogle
    Key = Ctrl + b
  ]
]

The I could upgrade settings file and convert SelectionHandlers and ExternalViewers to Commands section and deprecate them.

from sumatrapdf.

from sumatrapdf.