Comments (4)
Nice catch! I had overlooked about that.
I will change codes soon.
from h2spec.
Fixed.
If you still have a problem, please reopen this issue.
from h2spec.
Thank you for the quick fix!
from h2spec.
As an afterthought, it might be worth to consider adding a strict mode that permits the peer to send connection errors (or to just close the connection) in place of stream errors.
note: draft-16 6.8 states: "An endpoint might choose to close a connection without sending GOAWAY for misbehaving peers", which IMO means that it is permitted for an implementation compliant to the spec to abruptly close the connection for any of the connection errors or stream errors, taking the statement in 5.4.1 (shown above) into consideration.
from h2spec.
Related Issues (20)
- http2/ 4.2.3 doesn't make big enough headers
- Expected `GOAWAY (FRAME_SIZE_ERROR)` got `connection error: FRAME_SIZE_ERROR`?
- Building cross-platform HOT 1
- Should tests send goaway? HOT 1
- Adding New Test Group
- h2spec http2/6.5.3/1 -p 9000 -o 5 : it hangs HOT 9
- HTTP2 spec section 3.5 error HOT 5
- Spec Http2/6.9.2/1 is racy HOT 2
- No DockerHub image 2.5.0 HOT 1
- h2spec http2/8 tests should accept 400 Bad Request HOT 7
- h2spec generic/5 test 1 should not send an HTTP header with an empty value HOT 2
- h2spec http2/3.5 test 2 should accept a cleartext HTTP/1.1 response if not TLS HOT 1
- Testing 5.1/1 has the wrong requirement (need GOAWAY with STREAM_CLOSED not PROTOCOL_ERROR) HOT 3
- stream errors HOT 4
- Skipping harmless frames HOT 3
- Supporting the new document for HTTP/2 (RFC 9113) HOT 1
- Doesn't server receiving GOAWAY frame have to close the connection ? HOT 2
- Order of response frames
- Typo in glide.yaml HOT 1
- Infinite loop in VerifyConnectionError HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from h2spec.