Comments (7)
Your understanding of the spec is correct. However, this test is expected that the stream is closed properly, by sending two "Dynamic Table Size Update". Does your implementation treats "Dynamic Table Size Update" of HPACK as decompression error?
from h2spec.
I believe so. I receive the two hpack dynamic size updates, detect the decompression error, send a GOAWAY w/ COMPRESSION_ERROR set as the reason, then terminate the connection.
I believe that the issue is the test uses TestStreamClose
(https://github.com/summerwind/h2spec/blob/master/4_3.go#L45) and in that function implementation, the test fails if it receives GOAWAY: https://github.com/summerwind/h2spec/blob/master/h2spec.go#L800
If I removed the GOAWAY frame before closing the connection, the test passed.
from h2spec.
This test is verifying that your implementation can handle correctly the dynamic table size update. If your implementation respond with GOAWAY, this test will be failed.
Why does your implementation treats the dynamic table size update as a decompression error?
from h2spec.
Ok, I understand the question.
The test sends two dynamic table size updates (0 and 4096) at the beginning of a single header block. The HPack spec contains the following:
A change in the maximum size of the dynamic table is signaled via a dynamic table size update (see Section 6.3). This dynamic table size update MUST occur at the beginning of the first header block following the change to the dynamic table size. In HTTP/2, this follows a settings acknowledgment (see Section 6.5.3 of [HTTP2]).
My interpretation of this is that a single header frame can contain at most one dynamic table update and it must be at the beginning of the frame.
I also see this:
This mechanism can be used to completely clear entries from the dynamic table by setting a maximum size of 0, which can subsequently be restored.
Again, my interpretation of this is that these dynamic updates must be in separate header frames.
I guess this is an incorrect interpretation?
from h2spec.
In paragraph:
Multiple updates to the maximum table size can occur between the transmission of two header blocks. In the case that this size is changed more than once in this interval, the smallest maximum table size that occurs in that interval MUST be signaled in a dynamic table size update. The final maximum size is always signaled, resulting in at most two dynamic table size updates. This ensures that the decoder is able to perform eviction based on reductions in dynamic table size (see Section 4.3).
I was reading "Multiple updates to the maximum table size" as receiving HTTP/2 settings frames w/ the max table size setting set, not multiple dynamic updates in the header block.
from h2spec.
the smallest maximum table size that occurs in that interval MUST be signaled in a dynamic table size update. The final maximum size is always signaled, resulting in at most two dynamic table size updates.
I think this states that 2 dynamic table size updates can occur at the front of encoded header block. If you still think it shouldn't, please ask this on IETF httpbis mailing list.
from h2spec.
Ok, thanks. I believe this is a misread on my part. Sorry for the trouble.
from h2spec.
Related Issues (20)
- http2/ 4.2.3 doesn't make big enough headers
- Expected `GOAWAY (FRAME_SIZE_ERROR)` got `connection error: FRAME_SIZE_ERROR`?
- Building cross-platform HOT 1
- Should tests send goaway? HOT 1
- Adding New Test Group
- h2spec http2/6.5.3/1 -p 9000 -o 5 : it hangs HOT 9
- HTTP2 spec section 3.5 error HOT 5
- Spec Http2/6.9.2/1 is racy HOT 2
- No DockerHub image 2.5.0 HOT 1
- h2spec http2/8 tests should accept 400 Bad Request HOT 7
- h2spec generic/5 test 1 should not send an HTTP header with an empty value HOT 2
- h2spec http2/3.5 test 2 should accept a cleartext HTTP/1.1 response if not TLS HOT 1
- Testing 5.1/1 has the wrong requirement (need GOAWAY with STREAM_CLOSED not PROTOCOL_ERROR) HOT 3
- stream errors HOT 4
- Skipping harmless frames HOT 3
- Supporting the new document for HTTP/2 (RFC 9113) HOT 1
- Doesn't server receiving GOAWAY frame have to close the connection ? HOT 2
- Order of response frames
- Typo in glide.yaml HOT 1
- Infinite loop in VerifyConnectionError HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from h2spec.