Giter VIP home page Giter VIP logo

Comments (3)

RemingtonRohel avatar RemingtonRohel commented on August 24, 2024

I don't agree that this is a bug, this was the intended design of the function find_records_by_datetime(). I chose a small tolerance as default for my use case of wide-beam experiments, but it is still fully functional for narrow beam experiments as you mentioned.

The function actually matches any records within tolerance of your scan_index datetime value, so with tolerance = 60 seconds you will get two minutes worth of records (60 seconds on either side), centered around the scan_index time.

I agree though that it would be cleaner to have two separate kwargs, since passing a datetime as scan_index means that you haven't exactly passed in an index, you've passed in a time. Definitely could be much clearer. This would mean handling some kwargs more carefully, but that's not too difficult.

from pydarn.

billetd avatar billetd commented on August 24, 2024

Yes I agree find_records_by_datetime() is working as intended, though maybe a default shouldn't be for wide-beam at this time as the majority of data is narrow beam, 1-min scans. Two keywords would be best but I don't think its a priority right now, at least not as much as changing the default tolerance.

With tolerance=60, I just realised it was because I was looking at twofsound data, so you need 60 seconds there because of alternating channels.

from pydarn.

RemingtonRohel avatar RemingtonRohel commented on August 24, 2024

Fair enough, I agree that changing the default is a good idea.

from pydarn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.