Giter VIP home page Giter VIP logo

Comments (6)

vincentfretin avatar vincentfretin commented on June 12, 2024 1

That's great you find a fix. Hard to tell if it's a good one or not without a full example of what you're doing and how you switch between the two controls. You can close the issue if this change looks good to you.

from superframe.

khalidmaquilang avatar khalidmaquilang commented on June 12, 2024

okay I got it.. i just added an event listener

let transform_controls = new TransformControls(camera, scene.sceneEl.renderer.domElement)
    transform_controls.attach(elem)
    transform_controls.addEventListener( 'dragging-changed', function ( event ) {
        current_camera = document.getElementById('camera')
        if (event.value) {
            current_camera.pause()
            return
        }

        current_camera.play()
    } )

from superframe.

khalidmaquilang avatar khalidmaquilang commented on June 12, 2024

another problem is that after I move the entity, the camera returns to its target coordinate.. it doesn't stay in the previous position

from superframe.

vincentfretin avatar vincentfretin commented on June 12, 2024

This seems to be a problem specific to your project code. You'll probably have a better chance of finding a solution to your issue on WebXR Discord aframe channel if you provide a glitch example of the issue.

from superframe.

khalidmaquilang avatar khalidmaquilang commented on June 12, 2024

I fixed the problem by removing controls.target = this.target.copy(data.target); in the update function of orbit-control

from superframe.

khalidmaquilang avatar khalidmaquilang commented on June 12, 2024

For documentation purposes here is my code:

    const elem = document.getElementById(primitive.id).getObject3D('mesh')    
    const camera = document.getElementById('camera').getObject3D('camera')

    let transform_controls = new TransformControls(camera, scene.sceneEl.renderer.domElement)
    transform_controls.attach(elem)
    transform_controls.addEventListener('dragging-changed', function (event) {
        // disable orbit control when doing transform(translate, rotate and scale)
        orbit_control.enabled = !event.value
    })
    transform_controls.addEventListener('objectChange', (e) => {
        // update selected model
        updateControlModel(e.target.object)
    })
    scene.object3D.add(transform_controls)

in my orbit-control.js

                    // controls.target = this.target.copy(data.target);
                    controls.cursor = this.cursor.copy(data.cursor);
                    controls.autoRotate = data.autoRotate;
                    controls.autoRotateSpeed = data.autoRotateSpeed;
                    controls.dampingFactor = data.dampingFactor;
                    controls.enabled = data.enabled;
                    controls.enableDamping = data.enableDamping;
                    controls.enablePan = data.enablePan;
                    controls.enableRotate = data.enableRotate;
                    controls.enableZoom = data.enableZoom;
                    controls.keyPanSpeed = data.keyPanSpeed;
                    controls.maxPolarAngle = THREE.MathUtils.degToRad(data.maxPolarAngle);
                    controls.maxAzimuthAngle = THREE.MathUtils.degToRad(data.maxAzimuthAngle);
                    controls.maxDistance = data.maxDistance;
                    controls.minDistance = data.minDistance;
                    controls.minPolarAngle = THREE.MathUtils.degToRad(data.minPolarAngle);
                    controls.minTargetRadius = data.minTargetRadius;
                    controls.maxTargetRadius = data.maxTargetRadius;
                    controls.minAzimuthAngle = THREE.MathUtils.degToRad(data.minAzimuthAngle);
                    controls.minZoom = data.minZoom;
                    controls.maxZoom = data.maxZoom;
                    controls.panSpeed = data.panSpeed;
                    controls.rotateSpeed = data.rotateSpeed;
                    controls.screenSpacePanning = data.screenSpacePanning;
                    controls.zoomSpeed = data.zoomSpeed;
                    controls.zoomToCursor = data.zoomToCursor;

from superframe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.