Filter Width Pan Slider doesn't invalidate properly about surge HOT 7 CLOSED

Huh I was about to add a comment like "do you still see this" but then I realized that I see it too.

However it isn't the pan slider that is missing. It is the "slider below pan".

   // pan2 control
   if ((synth->storage.getPatch().scene[current_scene].filterblock_configuration.val.i !=
        fb_stereo) &&
       (synth->storage.getPatch().scene[current_scene].filterblock_configuration.val.i != fb_wide))
   {
      i = synth->storage.getPatch().scene[current_scene].width.id;
      if (param[i] && dynamic_cast<CSurgeSlider*>(param[i]) != nullptr)
         ((CSurgeSlider*)param[i])->disabled = true;
   }

is the code that activates it. So when you set the filter configuration to "wide" it appears, kinda. You need to click to force a repaint. And when you turn off wide it doesn't undisplay.

So the bug here is a bit more subtle. It is that "wide mode on filter doesn't force draw; and disabled wide mode is blank". Ideally you'd make filter->disabled=true not be so disabled!

But more importantly when you toggle wide mode, you want to do a param refresh which forces a createOrRedraw. Something about the setDirty around line 1938 of SurgeGUIEditor isn't enough.

from surge.

Actually @esaruoho can you rename this issue to "Filter Width Pan Slider doesn't invalidate properly" so we know what to fix?

from surge.

@baconpaul i updated the title and will look again so can rewrite the original ticket. Thanks for the sleuthwork!

from surge.

yeah this slider only appear in the wide mode, in the others the signal path is mono up until that point

from surge.

Thanks @kurasu - the invalidation code means it doesn’t immediately toggle on off when you go into and out of wide, so there’s a tiny bug let there somewhere, but we can fix that soon enough I’m sure!

from surge.

I have this invalidation fixed. It's just behind #148. I could cherry pick it over and sweep it but if folks like the logger it is easier to just wait and sweep it then. baconpaul/surge branch width-invalidate-75 is the tiny change needed.

from surge.

Fixed at head; closing.

from surge.