dynamic import about terser error about webpack-book HOT 16 CLOSED

Can you push your project to GitHub so I can have a closer look? It feels like something in Babel configuration.

I have a reference implementation at https://github.com/survivejs-demos/webpack-demo .

from webpack-book.

Yes, when I added the "targets: { "esmodules": true } "in the babel file, the error disappeared

from webpack-book.

babel/babel#9849

from webpack-book.

https://github.com/heart-er/test-webpack

This is my webpack, please help me to check if I can remove target modules in babel

from webpack-book.

I know "modules": false is important for webpack but the targets bit is new to me. I wonder if something has changed there in the past months. Let me verify and get back to you latest tomorrow.

from webpack-book.

I tried out your project. If I reduce the configuration to the following it still works:

{
    "presets": [
        [
            "@babel/preset-env",
            {
                "modules": false
            }
        ]
    ]
}

That "modules": false bit is crucial as otherwise webpack won't be able to use tree shaking properly.

Can you push code that's leading to the error in your repository?

from webpack-book.

The development environment is fine, but if you execute npm run build, it will throw an error.

from webpack-book.

you can remove target within my repository and excute npm run build.

from webpack-book.

Ok, I see now. I can reproduce the issue if I empty your .browserslistrc.

The problem has to do with Terser and its capabilities in minifying the code. It's crashing as it cannot deal with the syntax. It can be something as simple as a trailing comma.

Here's more information: webpack-contrib/terser-webpack-plugin#114 . It's possible setting the ecma option to 8 at terser options (see the minifying chapter) could resolve the issue if you want to compile for the most modern browsers only (I assume removing targets from browserslistrc is doing this exactly).

from webpack-book.

So, if I remove the target, it needs to be compatible with the old browser, what should I do?

from webpack-book.

from webpack-book.

Which browsers do you want to target?
…
On 03.03.2021, at 12:08, heart @.***> wrote:  So, if I remove the target, it needs to be compatible with the old browser, what should I do? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

IE 10 +

from webpack-book.

Ok, in that case it's enough to set .browserslistrc like this:

IE >= 10

I checked with your build command and it compiles now with this.

from webpack-book.

Thank you very much!

from webpack-book.

Cool, let's close?

from webpack-book.

Ok

from webpack-book.