Giter VIP home page Giter VIP logo

Comments (12)

suve avatar suve commented on August 26, 2024

Yes, currently the comma is not recognized as a separator. This was an intentional choice, as the tool was developed mainly for use with Fedora, and Fedora's Packaging Guidelines state that only and and or should be used as separators.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_dual_licensing_scenarios
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios

I suppose we could try interpreting the comma as a separator, but that brings about the question - how to interpret it? Interpreting the comma as or can create false-negatives, and interpreting it as and can create false positives. Arguably, the second option is better, since it fits the "non-free until proven otherwise" approach better.

from vrms-rpm.

nemobis avatar nemobis commented on August 26, 2024

from vrms-rpm.

christianitis avatar christianitis commented on August 26, 2024

This also happens to me. I'm on OpenSUSE Tumbleweed, and it's listing around %50 of my packages as nonfree solely because they have multiple licenses. Considering Fedora is now essentially dead, and many of it's former users are now moving to Suse, shouldn't this be fixed?

from vrms-rpm.

suve avatar suve commented on August 26, 2024

Considering Fedora is now essentially dead

What.

Also, please give an example. If this is caused by packages using

LicenceOne, LicenceTwo

then check my comment above about handling the comma as a licence separator.

from vrms-rpm.

christianitis avatar christianitis commented on August 26, 2024

Considering Fedora is now essentially dead

What.

Sorry, meant CentOS, not Fedora. Leap has been getting a lot of refugees from CentOS.

from vrms-rpm.

christianitis avatar christianitis commented on August 26, 2024

Also, please give an example. If this is caused by packages using

LicenceOne, LicenceTwo

then check my comment above about handling the comma as a licence separator.

I think I see the problem: it seems that the license detector is case-sensitive, and does not recognize multi-licensed packages which use capital AND/OR as seperators.

vrms-rpm --explain returns this:
vlc GPL-2.0-or-later AND LGPL-2.1-or-later x11-tools GPL-2.0-or-later AND MIT yast2-journal GPL-2.0-only OR GPL-3.0-only
et cetera et cetera.

Notice how the ANDs and ORs are capitalized. I think that may be the problem.
This should be a simple fix. I'd do it myself if not for my lack of knowledge of the C programming language.

from vrms-rpm.

suve avatar suve commented on August 26, 2024

Sorry, meant CentOS, not Fedora.

Oh yeah, agreed on that. With the announcement of CentOS Stream - which meant that CentOS stopped being "free RHEL without the branding" - a lot of people started migrating. I've heard of Rocky Linux continuing the idea.

Thanks for the examples. Yes, the current code performs a case-sensitive search when looking for and/or joiners. Making this case-insensitive is a simple change.

from vrms-rpm.

christianitis avatar christianitis commented on August 26, 2024

Sorry, meant CentOS, not Fedora.

Oh yeah, agreed on that. With the announcement of CentOS Stream - which meant that CentOS stopped being "free RHEL without the branding" - a lot of people started migrating. I've heard of Rocky Linux continuing the idea.

Thanks for the examples. Yes, the current code performs a case-sensitive search when looking for and/or joiners. Making this case-insensitive is a simple change.

Awesome, glad I could help. And thank you for rewriting this for RPM-based systems!

from vrms-rpm.

suve avatar suve commented on August 26, 2024

I pushed some initial support for case-insensitive and/or joiners to the case-insensitive-joiners branch. While the code seems to work fine, the running time is roughly +33% compared to the old solution, so I want to take a bit more time and think on how to improve that.

from vrms-rpm.

nmonti avatar nmonti commented on August 26, 2024

This issue happened to me with the following libraries. The bolded are red in terminal:

 - librados2
   (LGPLv2.1 or LGPLv3) and CC-BY-SA-3.0 and GPLv2 and **Boost-1.0** and BSD and MIT
 - librbd1
   (LGPLv2.1 or LGPLv3) and CC-BY-SA-3.0 and GPLv2 and **Boost-1.0** and BSD and MIT
 - lttng-ust
   **LGPLv2.1, MIT** and GPLv2

Boost is free, and I'm not sure what caused LGPLv2.1, MIT to be flagged.

from vrms-rpm.

suve avatar suve commented on August 26, 2024

@nmonti as mentioned earlier, X, Y is recognized as a single name, not (X or Y) nor (X and Y).

from vrms-rpm.

suve avatar suve commented on August 26, 2024

Opened issue #93 for tracking progress on adding support for comma-separated licence expressions. Closing this ticket.

from vrms-rpm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.