Comments (12)
Yes, currently the comma is not recognized as a separator. This was an intentional choice, as the tool was developed mainly for use with Fedora, and Fedora's Packaging Guidelines state that only and
and or
should be used as separators.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_dual_licensing_scenarios
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios
I suppose we could try interpreting the comma as a separator, but that brings about the question - how to interpret it? Interpreting the comma as or
can create false-negatives, and interpreting it as and
can create false positives. Arguably, the second option is better, since it fits the "non-free until proven otherwise" approach better.
from vrms-rpm.
from vrms-rpm.
This also happens to me. I'm on OpenSUSE Tumbleweed, and it's listing around %50 of my packages as nonfree solely because they have multiple licenses. Considering Fedora is now essentially dead, and many of it's former users are now moving to Suse, shouldn't this be fixed?
from vrms-rpm.
Considering Fedora is now essentially dead
What.
Also, please give an example. If this is caused by packages using
LicenceOne, LicenceTwo
then check my comment above about handling the comma as a licence separator.
from vrms-rpm.
Considering Fedora is now essentially dead
What.
Sorry, meant CentOS, not Fedora. Leap has been getting a lot of refugees from CentOS.
from vrms-rpm.
Also, please give an example. If this is caused by packages using
LicenceOne, LicenceTwo
then check my comment above about handling the comma as a licence separator.
I think I see the problem: it seems that the license detector is case-sensitive, and does not recognize multi-licensed packages which use capital AND/OR as seperators.
vrms-rpm --explain
returns this:
vlc GPL-2.0-or-later AND LGPL-2.1-or-later x11-tools GPL-2.0-or-later AND MIT yast2-journal GPL-2.0-only OR GPL-3.0-only
et cetera et cetera.
Notice how the ANDs and ORs are capitalized. I think that may be the problem.
This should be a simple fix. I'd do it myself if not for my lack of knowledge of the C programming language.
from vrms-rpm.
Sorry, meant CentOS, not Fedora.
Oh yeah, agreed on that. With the announcement of CentOS Stream - which meant that CentOS stopped being "free RHEL without the branding" - a lot of people started migrating. I've heard of Rocky Linux continuing the idea.
Thanks for the examples. Yes, the current code performs a case-sensitive search when looking for and
/or
joiners. Making this case-insensitive is a simple change.
from vrms-rpm.
Sorry, meant CentOS, not Fedora.
Oh yeah, agreed on that. With the announcement of CentOS Stream - which meant that CentOS stopped being "free RHEL without the branding" - a lot of people started migrating. I've heard of Rocky Linux continuing the idea.
Thanks for the examples. Yes, the current code performs a case-sensitive search when looking for
and
/or
joiners. Making this case-insensitive is a simple change.
Awesome, glad I could help. And thank you for rewriting this for RPM-based systems!
from vrms-rpm.
I pushed some initial support for case-insensitive and
/or
joiners to the case-insensitive-joiners
branch. While the code seems to work fine, the running time is roughly +33% compared to the old solution, so I want to take a bit more time and think on how to improve that.
from vrms-rpm.
This issue happened to me with the following libraries. The bolded are red in terminal:
- librados2
(LGPLv2.1 or LGPLv3) and CC-BY-SA-3.0 and GPLv2 and **Boost-1.0** and BSD and MIT
- librbd1
(LGPLv2.1 or LGPLv3) and CC-BY-SA-3.0 and GPLv2 and **Boost-1.0** and BSD and MIT
- lttng-ust
**LGPLv2.1, MIT** and GPLv2
Boost is free, and I'm not sure what caused LGPLv2.1, MIT
to be flagged.
from vrms-rpm.
@nmonti as mentioned earlier, X, Y
is recognized as a single name, not (X or Y)
nor (X and Y)
.
from vrms-rpm.
Opened issue #93 for tracking progress on adding support for comma-separated licence expressions. Closing this ticket.
from vrms-rpm.
Related Issues (20)
- Update Dutch translation for version 2.0 HOT 1
- Update Portuguese translation for version 2.0 HOT 3
- Update Turkish translation for version 2.0 HOT 3
- Update title README.md HOT 1
- Rename file LICENSE HOT 2
- Update readme text HOT 1
- Too many issues with README.md HOT 3
- src/lang.c: 2 * bad parameter to va_start ? HOT 4
- Add some black-box testing
- Respect the NO_COLOR environment variable
- vrms-rpm counts packages once for each version installed HOT 5
- Update translations for v2.3 release HOT 4
- SPDX grammar support HOT 1
- Numbers of installed packages reported by `vrms-rpm --list all` and `vrms-rpm --list none` as total sum, differ from each other HOT 2
- `vrms-rpm` lacks the ability to report full names of fake packages with GPG keys HOT 3
- Validate licensing exceptions in "spdx" classifier
- Improve WITH support in "loose" classifier HOT 1
- Add support for comma-separation to "loose" classifier
- Support lower-case SPDX operators HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vrms-rpm.