Comments (2)
As a quick example:
scala> val enc = new EncoderSpeed()
val enc: boopickle.EncoderSpeed = boopickle.EncoderSpeed@d59b6cb
scala> enc.writeInt(2100000000)
val res37: boopickle.Encoder = boopickle.EncoderSpeed@d59b6cb
scala> val bb = enc.asByteBuffer
val bb: java.nio.ByteBuffer = java.nio.HeapByteBuffer[pos=0 lim=4 cap=512]
scala> val dec = new DecoderSpeed(bb)
val dec: boopickle.DecoderSpeed = boopickle.DecoderSpeed@5f7509c8
scala> dec.buf.remaining
val res38: Int = 4
scala> dec.readIntArray()
java.lang.OutOfMemoryError: Java heap space
Would it make sense, when allocating (larger) arrays, to check if this allocation is reasonable ?
So something like:
def readIntArray(len: Int): Array[Int] = {
+ assert(buf.remaining() >= len * 4) // bail out if not
val array = new Array[Int](len)
buf.asIntBuffer().get(array)
buf.position(buf.position() + len * 4)
array
}
from boopickle.
I think this is a very good idea, surprised this is not already done.
In fact, this should be considered a security vulnerability, worthy of a CVE.
from boopickle.
Related Issues (20)
- publish for Scala 2.13.0-M5? HOT 6
- Publish for Scala 2.13 HOT 1
- Publish boopickle for Scala.js 1.0.0 HOT 14
- Maintenance HOT 7
- Release for scala.js 1.0 HOT 3
- Troubles with 1.3.2 release HOT 1
- Release 1.3.3 HOT 5
- Github actions release doesn't work HOT 2
- Support serializing scala 2.13 SeqMap
- Pickle Map with Any as value HOT 1
- Source path for Scala.js is wrong
- Dotty support HOT 1
- Support Pickler derivation with nested sealed traits for scala 3
- Scala 3 enums cause error at runtime HOT 1
- Scala 3 pickle format is not compatible with Scala 2 format HOT 5
- Is binary format сompatible with MessagePack? HOT 4
- Split Pickler into reader and writer, for small Scala.JS bundle sizes
- Unable to access pickled bytes
- Unknown integer coding error HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boopickle.