Giter VIP home page Giter VIP logo

Comments (4)

SethFalco avatar SethFalco commented on July 28, 2024

Thanks for trying the release candidate! Helps a lot to get feedback like this before the official release. 🙏🏽

This makes sense. I actually didn't export utilities on purpose to treat them as internal API only, but we can make a few exceptions for instances like these, I overlooked custom plugins.

I'll look into it this week!

By any chance, is your project/plugin open-source or source-accessible? I'm writing draft PRs to help projects migrate to SVGO v4 which gives me more exposure to how it's used and what problems people may encounter. No problem if not, but it could be nice to have the context to help me decide if anything else needs to be adjusted. Otherwise, once v4.0.0-rc.1 is out, just let me know if you have any other issues. 👍🏽

from svgo.

vltansky avatar vltansky commented on July 28, 2024

My project isn't open source, but I can share plugins with you privately for context if you are interested.
my mail [email protected]
We also importing types like XastElement, XastRoot, XastChild from svgo/lib/types
and import _collections from 'svgo/plugins/_collections';

i actually just migrated our plugins from svgo 2 to 3, so i'll be available during the 4 release candidates iterations so it will be easier for us to migrate :)

from svgo.

SethFalco avatar SethFalco commented on July 28, 2024

My project isn't open source, but I can share plugins with you privately for context if you are interested

Normally I'm very open for users to share files with me, (SVGs, SVGO configs, or how they're using SVGO), but in this case we'll set it aside as I don't want me seeing the plugins to impact what I feel I can personally contribute to this repository, or the potential disputes if I ever implement similar ideas.

Thanks for offering, though! <3

i'll be available during the 4 release candidates iterations so it will be easier for us to migrate :)

If you happen to notice any other objects/types from SVGO that you import, feel free to update me. Meanwhile, once v4.0.0-rc.1 is out (this weekend hopefully), you can also just say if you encounter any other problems.

from svgo.

vltansky avatar vltansky commented on July 28, 2024

We actually would be happy to open source plugins, just most of them are very specific for our use cases.

from svgo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.