IE8 throws an error when use of svg.js about svg.js HOT 5 CLOSED

Yes, IE8 is not supported, check the Compatibility section on github:
https://github.com/wout/svg.js

from svg.js.

Hey there,

I'm using svg.js for a project and it has been working great. I like the compactness. Great job!

Unfortunately, there are some IE8 users that I have to accommodate. I don't expect them to use or make use of SVGs. I hide the functionality with the useful SVG.supported flag. There's one problem though: My project relies on AMD and svg.js doesn't define anything, if SVG isn't supported. Thus, IE8 users get an SVG undefined error.

The culprit is on line 64 (dist/svg.js):

if (!SVG.supported) return false

My workaround looks like this:

if (!SVG.supported) {
    define('SVG', function() { return SVG; });
    return false;
}

After implementing this, I can still use the SVG.supported flag.
I would like to use bower to install your great library, but without this fix I won't be able to do it.
Does this look like a reasonable change request?

from svg.js.

Hi Kevin,

Thanks for this fix!
To be honest, I rarely test on IE8.

I will implement it in the next release.
A huge amount of work has been done since v0.32 and I expect to release in the next 14 days.

from svg.js.

HeyI

That was fast :)

I think it would be better to move the module definitions to the top,
instead of implementing my fix and having two defines. My proposed fix is kind of bad, because it only fits my needs (no CommonJs support). It's not good practice having two defines, especially if one is named ("SVG") and the other is anonymous. And having two anonymous defines is strictly prohibited, because the require optimizer will complain.

That's why I propose this:

this.SVG = function(element) {
    if (SVG.supported)
      return new SVG.Doc(element)
  }

if (typeof define === 'function' && define.amd)
    define(function() { return SVG })
else if (typeof exports !== 'undefined')
    exports.SVG = SVG

Looking forward to your next release.

from svg.js.

Great, thanks! Seems like a better place indeed as the SVG object is already defined anyway.

from svg.js.