Comments (1)
calebcartwright
commented on May 30, 2024
For anyone interested in working on this, a couple recent PRs have made it really simple to deliver this feature with a small final amount of work.
Basically, we just need to change the final arg from None to an option-wrapped HashMap reference that uses RUSTY_HOOK_GIT_PARAMS for the key and the value would be the args parameter in the run function (currently _args because it's not used yet).
Line 116 in 755cd44
Could also consider tweaking the cli to keep the Option<String> and passing that along to run, and conditionally set the value passed to run_command based on whether args is None or Some, with None and the HashMap respectively
Line 74 in 755cd44
Line 47 in 755cd44
from rusty-hook.
Related Issues (20)
- Exit gracefully from hook scripts when requisite bins missing
- Don't attempt to init during bin install
- Fix clippy warnings
- Setup Testspace publishing
- Switch to GitHub Actions
- Hooks fail when using toml array syntax for multi-commands in rusty-hook.toml HOT 2
- Allow for alternative path for config HOT 7
- constantly upgrading HOT 10
- Rename existing commit hooks HOT 1
- Improve handling of projects in sub-directories HOT 12
- Clarify/document hook commands executed in git root directory
- Document git hook files are automanaged HOT 1
- error: Found argument '' which wasn't expected, or isn't valid in this context HOT 7
- Release `0.12.0` ? HOT 3
- Differences to the altenative? HOT 2
- The git arguments are not properly passed by `%rh!` HOT 2
- Allow setting environment variables and map them with specific hook HOT 2
- Invalid rusty-hook config file HOT 1
- Pre-push hook does not work when it has a list as value HOT 1
- Using a custom script HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rusty-hook.