Giter VIP home page Giter VIP logo

Comments (1)

pablojan avatar pablojan commented on June 9, 2024

The exception recorded in the previous message was caused by an unexpected behavior of
DeltaStoreBasedWaveletState.cachedDeltas: this map must contain all deltas already applied to the the wavelet snapshot DeltaStoreBasedWaveletState.snapshot, but the exception shows that sometimes, the latest delta is not present in cachedDeltas, whereas snapshot already has been updated with it. Both data structures are updated in the method appendDelta() (see below) but in original code, invocation to cachedDeltas.put()is done outside the synchronized block.
With debugging code, it's demonstrated that cachedDeltas' map got desynchronized sometimes.

@Override
  public void appendDelta(WaveletDeltaRecord deltaRecord)
      throws OperationException {
    HashedVersion currentVersion = getCurrentVersion();
    Preconditions.checkArgument(currentVersion.equals(deltaRecord.getAppliedAtVersion()),
        "Applied version %s doesn't match current version %s", deltaRecord.getAppliedAtVersion(),
        currentVersion);



      if (deltaRecord.getAppliedAtVersion().getVersion() == 0) {
        Preconditions.checkState(lastPersistedVersion.get() == null);
        snapshot = WaveletDataUtil.buildWaveletFromFirstDelta(getWaveletName(), deltaRecord.getTransformedDelta());
        contributions = new WaveletContributions(deltasAccess.getWaveletName());
        contributions.apply(deltaRecord.getTransformedDelta());
      } else {
        // Avoid to update snapshot when it has being persisted
        synchronized (persistLock) {
          WaveletDataUtil.applyWaveletDelta(deltaRecord.getTransformedDelta(), snapshot);
          contributions.apply(deltaRecord.getTransformedDelta());
        }
      }


    // Now that we built the snapshot without any exceptions, we record the delta.
    cachedDeltas.put(deltaRecord.getAppliedAtVersion(), deltaRecord); <------- UNSAFE UPDATE

    // Increment counter controlling snapshot persistence
    deltasCountBeforeSnapshotStore++;
  }

from swellrt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.