Giter VIP home page Giter VIP logo

Comments (8)

wizche avatar wizche commented on August 23, 2024 1

Looks like the issue is only when the width field is not passed, adding it makes the workflow complete correctly

from screenshot-website.

wizche avatar wizche commented on August 23, 2024 1

Thanks for the quick fix

from screenshot-website.

rootwork avatar rootwork commented on August 23, 2024 1

Thank you!

from screenshot-website.

wizche avatar wizche commented on August 23, 2024

Same here, what I see is:

Run swinton/[email protected]
  with:
    source: http://www.centrometeolombardo.com/moduli/stazioni.php?lema
    destination: screenshot.png
    full-page: true
    delay: 0
Error: Protocol error (Emulation.setDeviceMetricsOverride): Invalid parameters Failed to deserialize params.width - BINDINGS: mandatory field missing at position 98
Error: The operation was canceled.

from screenshot-website.

swinton avatar swinton commented on August 23, 2024

That's really odd.

I have an end-to-end test suite which runs successfully: https://github.com/swinton/screenshot-website/actions/runs/534207319

Can you take a look at the end-to-end tests and let me know if there are differences in how you are running this action compared to what the end-to-end tests are doing?

from screenshot-website.

swinton avatar swinton commented on August 23, 2024

I suspect this is the culprit: 2567c41

We may need a default for width:

width:
description: 'Page width'
required: false

from screenshot-website.

swinton avatar swinton commented on August 23, 2024

OK, should be fixed now and available in v1.x, I have test coverage for this here: 3ed5001

Thanks for the bug report!

from screenshot-website.

danielo515 avatar danielo515 commented on August 23, 2024

It is still happening for me, and I'm using v1.X, can it be caused by something else?

from screenshot-website.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.