Giter VIP home page Giter VIP logo

Comments (8)

sankalp-khare avatar sankalp-khare commented on July 21, 2024 3

Yep. I cannot reproduce the issue in afe8afc (parent of 0d670af)

from spacemacs.

sankalp-khare avatar sankalp-khare commented on July 21, 2024 1

Looks like the issue was introduced in 0d670af:

  0 git … pull origin develop
From https://github.com/syl20bnr/spacemacs
 * branch                develop    -> FETCH_HEAD
Already up to date.

  0 git … bisect start develop a58a7d79b3713bcf693bb61d9ba83d650a6aba86
Bisecting: 9 revisions left to test after this (roughly 3 steps)
[2fb41e7c4c208354b02ae37dc3a012450d55e240] improve ess loading and fix `ess-inferior-r-mode-map` bug

  0 git … bisect good
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[3feb80bce68326ba11e2eda955912c82ed667af7] Fix helm-ls-git overrides (#16373)

  0 git … bisect bad
Bisecting: 2 revisions left to test after this (roughly 1 step)
[0d670aff0653cb708889913c6bf90251172c342e] Add some missing help key bindings to spacemacs-defaults (#16368)

  0 git … bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[afe8afc19d527a7c8e0c8f07755fb1d99efe169e] [spacemacs-editing-visual] Disable vhl occur extension in Emacs 28+

  0 git … bisect good
0d670aff0653cb708889913c6bf90251172c342e is the first bad commit
commit 0d670aff0653cb708889913c6bf90251172c342e
Author: Aaron Zeng <[email protected]>
Date:   Sat May 11 17:07:01 2024 -0400

    Add some missing help key bindings to spacemacs-defaults (#16368)
    
    * [spacemacs-defaults] Add SPC h d F for describe-face
    
    This key binding is already used for counsel-describe-face in the ivy
    layer.
    
    * [spacemacs-defaults] Move some help keys from the compleseus layer
    
    These key bindings are for built-in commands (which compleseus
    enhances, but does not rename).  It would be useful to have these key
    bindings available even if no completion layer is enabled.

 layers/+completion/compleseus/packages.el           | 3 ---
 layers/+spacemacs/spacemacs-defaults/keybindings.el | 4 ++++
 2 files changed, 4 insertions(+), 3 deletions(-)

from spacemacs.

sankalp-khare avatar sankalp-khare commented on July 21, 2024 1

@fnussbaum thanks for pouncing on this quick and addressing it!

from spacemacs.

fnussbaum avatar fnussbaum commented on July 21, 2024

Setting a global keybinding starting with M-m to describe-mode before Helm is loaded seems to break Helm:

    (define-key map (kbd "M-m")        #'helm-toggle-all-marks)
    ...
    ;; Use `describe-mode' key in `global-map'.
    (dolist (k (where-is-internal #'describe-mode global-map))
      (define-key map k #'helm-help))

(from https://github.com/emacs-helm/helm/blob/master/helm-core.el#L392-L490)

The Ivy layer already implements a workaround which could be moved and used here as well: https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Bcompletion/ivy/funcs.el#L346-L362

from spacemacs.

vitaminace33 avatar vitaminace33 commented on July 21, 2024

I am suffering of this problem in home buffer. I can't do much, not even visiting a file.

I have pulled Spacemacs last updates and updated packages.

Upon start, I receive the following errors.

⛔ Error (use-package): popwin/:config: Wrong type argument: listp, window-purpose/save-dedicated-windows
⛔ Error (use-package): window-purpose/:config: Assertion failed: (listp args)

M-m f f gives

Key sequence M-m h d m starts with non-prefix key M-m

from spacemacs.

vitaminace33 avatar vitaminace33 commented on July 21, 2024

After checking out afe8afc , key bindings work again. However, the aforementioned errors (use-package) persist.

from spacemacs.

rawenous avatar rawenous commented on July 21, 2024

Maybe @bcc32 wants to take a look

from spacemacs.

fnussbaum avatar fnussbaum commented on July 21, 2024

Upon start, I receive the following errors.

⛔ Error (use-package): popwin/:config: Wrong type argument: listp, window-purpose/save-dedicated-windows
⛔ Error (use-package): window-purpose/:config: Assertion failed: (listp args)

It might be best to open a separate issue for this including system info. I cannot reproduce the errors on my setup.

from spacemacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.