Giter VIP home page Giter VIP logo

Comments (4)

javiereguiluz avatar javiereguiluz commented on May 18, 2024

Thanks for reporting this problem. I consider it a bug because we intend to support even PHP 5.3, so this problem shouldn't happen. And given that the ircmaxell/password-compat library doesn't affect the application if you use PHP 5.5 or higher, I think it's safe to always include it.

We'll be very happy if you submit a PR with this change. Thanks!

PS: I know that it may look weird, but in our composer.json file we sort dependencies alphabetically and align them with white spaces. Please keep in mind this weirdness when adding the new dependency. Thanks!

from demo.

stof avatar stof commented on May 18, 2024

looks like a good idea to me. Our demo should run on as many versions of PHP as possible to make it simpler to use.

from demo.

stof avatar stof commented on May 18, 2024

@javiereguiluz I would be in favor of removing the alignment for the same reason we don't align => in arrays (even though incenteev/composer-parameter-handler already puts the min length high enough for most packages...)

from demo.

dosten avatar dosten commented on May 18, 2024

@stof 👍

from demo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.