Compatibility with FrameworkBundle Test Traits about symfony-bundle-test HOT 2 CLOSED

Hm.. I added that method in the Symfony code base.

What about removing it from BaseBundleTestCase? That will require a new major version, but it is in the correct direction.

from symfony-bundle-test.

I took a closer look and yes, this could be a good idea.

I have already tested how it is usable:

<?php

namespace SoureCode\Bundle\Token\Tests;

use DAMA\DoctrineTestBundle\DAMADoctrineTestBundle;
use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
use Nyholm\BundleTest\AppKernel;
use Stof\DoctrineExtensionsBundle\StofDoctrineExtensionsBundle;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use MyCustomBundle;

abstract class MyAbstractBundleTestCase extends KernelTestCase
{

    protected static function createKernel(array $options = [])
    {
        KernelTestCase::$class = AppKernel::class;

        /**
         * @var AppKernel $kernel
         */
        $kernel = parent::createKernel($options);

        $kernel->addBundle(DoctrineBundle::class);
        $kernel->addBundle(DAMADoctrineTestBundle::class);
        $kernel->addBundle(StofDoctrineExtensionsBundle::class);
        $kernel->addBundle(MyCustomBundle::class);
        $kernel->addConfigFile(__DIR__.'/config.yml');

        return $kernel;
    }
}

To use it like this we need to take some changes in the AppKernel.

• The constructor is not compatible with the createKernel implementation in the KernelTestCase
  

  symfony-bundle-test/src/AppKernel.php

  Line 51 in bcf6a3a

  public function __construct($cachePrefix)

  -    public function __construct($cachePrefix)
  +    public function __construct(string $environment, bool $debug)

• The cache prefix shouldn't be the environment.
  

  symfony-bundle-test/src/AppKernel.php

  Line 54 in bcf6a3a

  $this->cachePrefix = $cachePrefix;

  
  I think we could add a setter for that and set the default value to uniqid('cache')?
  

  symfony-bundle-test/src/BaseBundleTestCase.php

  Line 73 in bcf6a3a

  $this->kernel = new $class(uniqid('cache'));

from symfony-bundle-test.