Comments (5)
This sounds like an issue to be brought up in symengine issues list. I don't think it is relevant to the paper as it stands. The paper isn't even about symengine.
from sympy-paper.
I realize the issue is closed, but for future discussion.
"Full AKS" needs better definition. The algorithm from the original AKS paper? The revised (primality_v6) paper that has Lenstra's improvements? Other improvements such as Voloch or Bernstein 2003 (which run many orders of magnitude faster)?
In my experience, many AKS implementations are incorrectly implemented, making the benchmarking results of dubious merit. This of course applies to most software, but AKS is typically so glacially slow that people don't want to wait hours, days, or weeks for even a single trivially-small number to complete, so they often don't properly test.
The majority of the time is in the many modular polynomial congruency tests. These can be run in parallel, which would give some measure of scalability. The tests themselves boil down to doing modular polynomial squaring / multiplication. Implementations differ, which would make scalability comparisons tricky. E.g. binary segmentation boils the problem down to large integer multiplication, which will perform differently than a loop doing operations per polynomial term (the former is faster with GMP).
This isn't the right venue to have a conversation about this, but some things to consider for when you open it somewhere else.
from sympy-paper.
@danaj Thanks for the info, but I think you should open this issue in the SymEngine and/or SymPy benchmarks repository. I closed it because I don't think this is within scope of this paper.
from sympy-paper.
Oh sorry, I didn't realize that someone else opened this issue. Whoever cares about it should open the conversation where appropriate.
from sympy-paper.
Yes, somewhere else is more appropriate. I thought the comments provided some reasons why I believe this isn't a small task that would be appropriate to add to the paper without a lot more thought and work, even assuming it was decided to be relevant.
from sympy-paper.
Related Issues (20)
- QM section too big HOT 2
- There is no reference to the supplementary material HOT 3
- Sympy.stats description? HOT 5
- LaTeX output in REPL? HOT 1
- Anything else need to be done before submitting to PeerJ? HOT 3
- Authorship Criteria HOT 34
- Editors and reviewers HOT 14
- Peer reviews are in HOT 23
- Peer reviews checklist HOT 11
- Technical changes checklist HOT 12
- Reviewer 3 rewrite checklist HOT 5
- HAL upload HOT 3
- Some changes needed HOT 17
- Things to do better next time HOT 1
- Minor revisions HOT 5
- Article Approval HOT 30
- Accepted HOT 2
- Confirm participation in open peer review HOT 1
- Proofing PDF HOT 18
- Paper has been published HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sympy-paper.