Giter VIP home page Giter VIP logo

Comments (4)

wooorm avatar wooorm commented on August 24, 2024

Hmm, that’s funky! a) why? and b) how should we do this?

from hast-util-sanitize.

esatterwhite avatar esatterwhite commented on August 24, 2024

Well I want comments in the html basically.
I'm using HAST to generate html documents from user input via JSON api. So in translating to html, its exceptionally helpful to use html comments to debug.

I use this package to remove scripts, clean up html, etc. But it's also removing my comment markers.

{
   "type": "conversation"
  , ... options
}
<!-- START BLOCK CONVERSATION -->
   ... 3000 lines of generated html
<!-- END BLOCK CONVERSATION -->

That is all I'm really after.

I have a fork, where i did this

const NODES = {
  root: {children: all}
, element: {
    tagName: handleTagName
  , properties: handleProperties
  , children: all
  }
, text: {value: handleValue}
, comment: {value: handleValue}
, '*': {
    data: allow
  , position: allow
  }
}

that allows them, just not sure if that is the most efficient thing? of if you know of a better way?

from hast-util-sanitize.

wooorm avatar wooorm commented on August 24, 2024

That works for your fork, as it allows every comment, right? but that’s no how GH does it, and should be configurable I think.

I think we should check some property in the schema, roughly around here, to see if comments should be allowed?

from hast-util-sanitize.

wooorm avatar wooorm commented on August 24, 2024

@esatterwhite Are you into writing a PR for this?

from hast-util-sanitize.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.