Do not use `Omit` type about hast-util-to-html HOT 9 CLOSED

Awesome! I'll make a pull request to fix this issue.

from hast-util-to-html.

@wooorm Hmm I think we can just close this issue now. I've checked the code again and I like the fix currently applied. We use Omit only once in this package so I don't think it is worth to configure the rule in package.json.

from hast-util-to-html.

OK! Thanks for looking into it & working on it!

from hast-util-to-html.

In my opinion, the rule can be ignored. Omit doesn't check the omitted props exist in StringifyEntitiesOptions. So if we replace it with Except from type-fest, it would be a little bit helpful for us to detect trivial typos when we rename the omitted props in StringifyEntitiesOptions. And I don't think we would like to rename them that often. So i think we can just disable banning usage of Omit rather than introducing more dev deps.

@ChristianMurphy How do you think?

from hast-util-to-html.

I'd agree, I think adding another devDependency would like cause more frustration than the benefit Except brings. We can probably safely disable this rule.

from hast-util-to-html.

@wooorm How can I reproduce the error message? Apparently we aren't using typescript-eslint rules for this repository.

from hast-util-to-html.

I think updating dtslint to 3 gave me that error.
Xo does have typescript-eslint internally I believe

from hast-util-to-html.

Ah, I turned them off while updating: 1b34d25

from hast-util-to-html.

I see. I'll discard the comment and try to fix it again.

from hast-util-to-html.