Type doesn't work when using array of tests about unist-util-visit HOT 7 CLOSED

@wooorm The typo mislead me. I thought search was equal to ['textDirective', 'leafDirective', 'containerDirective'] and the visitor function was used as the third parameter.

Your solution does work. Thanks! However, ideally it would be great that the type would be able to properly narrow the visitor function. Although, I don't know if that's actually possible with TypeScript.

from unist-util-visit.

The problem is that TS sees an array (['a', 'b']) as string[], and then we can’t do anything with it anymore. We could try and add support for as const syntax:

    const search: Test = [
      "textDirective",
      "leafDirective",
      "containerDirective"
    ] as const
    visit(tree, search, (node) => {

(doesn’t work), but then again I don’t think this behavior is intuitive, I don’t think folks would think that they’d have to do that

from unist-util-visit.

TS doesn’t like arrays of things.
You can always get around it:

visit(tree, (node) => {
  if (node.type === "textDirective" || node.type === "leafDirective" || node.type === "containerDirective") {
    // things.
  }
})

from unist-util-visit.

@wooorm this still fails for what I'm trying to achieve since the node parameter isn't properly typed to include the properties name and attributes.

from unist-util-visit.

I don’t know what you’re trying to achieve? It’s apparently different from what you explained before or have in the codesandbox?

The node parameter is properly typed if you properly type tree

P.S.: I had a typo in the above code where search existed but shouldn’t have existed

from unist-util-visit.

Here is your CS changed to make it work: https://codesandbox.io/s/react-markdown-debug-forked-4iimg.
For more info on using types with remark-directive, see its readme: https://github.com/remarkjs/remark-directive#types

from unist-util-visit.

I believe this is a typescript limitation that can’t be changed. I’m open to documenting it. Or adding as const support.

from unist-util-visit.