Comments (6)
It's not just legacy, there's a technical reason behind it. When creating a new template, you are writing the initial template texts at the page /templates/new/
. At this time, the template is not saved yet in the API/database and does not have an ID yet. Uploading images at this stage is not possible, because the API does not know which template to assign the images to. Users have to save the template once (and are redirected to /templates/<id>/
) in order to upload images.
I think we should change the behavior to immediately create a new empty template in the API to allow image uploads, instead of using an intermediate page. This change, has the effect that users are no longer able to cancel template creation, because the template resource is already created in the API/database.
When creating templates from findings of existing project, there is an intermediate page too where the template is not created in the API yet (and therefore image upload is not possible). This intermediate page is intended to remove any customer-specific infos from the template before saving it. I think we should not modify this page. If the template would be saved immediately, customer infos will remain in the template's history. We should give users the chance to remove those sensitive customer infos to not end up in the template and history for everyone to see.
from sysreptor.
Thanks for this hint.
I think this is due to legacy reasons because in the past it wasn't possible to add images to finding templates.
You should, however, be able to add images by just pasting them to the markdown editor.
from sysreptor.
I had a suspicion it might've been because of historical reasons.
It's good to know that copy/past will still work! But the lack of the button suggests that an image wouldn't be possible at all, so it'd be great if this little bug gets fixed in a future release.
Thank you for your swift response!
from sysreptor.
Definitely. 👍
from sysreptor.
Thank you for your thorough analysis @MWedl! I really appreciate it.
It's an interesting situation for sure, with lots of factors to weigh. I can definitely live with it if my original issue is not tackled, because it can be explained why it happens. If you feel this issue will not be addressed, please feel free to resolve this issue ticket.
from sysreptor.
Implemented in https://github.com/Syslifters/sysreptor/releases/tag/2024.49
from sysreptor.
Related Issues (20)
- Users page accessible without superuser mode HOT 1
- Cookies: stricter settings and conflicts with other apps HOT 4
- reportcreator_api.archive.crypto.base.CryptoError: Either a key or a multiple available keys must be given HOT 3
- reptor burp error not upload note or templet HOT 25
- Loading additional templates error HOT 2
- update.sh breaks execute right / crontab docu update HOT 3
- Expected behavior after export/import to a new Sysreptor instance? HOT 2
- Header Issues // Vue Utilization HOT 3
- "Could not establish WebSocket connection" HOT 1
- "Could not establish WebSocket connection" - improve update.sh script HOT 1
- Updated from 2024.15 to 2024.55, caused Design template to stop working HOT 5
- stuck at pid 26 HOT 2
- Languagetool installation fails because of missing slash in Dockerfile HOT 2
- Getting ERROR while publishing the report HOT 1
- Feature Request: Store Websocket Fallback Option
- Inconsistent spell checking HOT 1
- Link instructions how to set BACKUP_KEY
- Sorting Finding Templates causes the application to crash HOT 1
- failed to register layer: failed to Lchown "/dev/tty" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sysreptor.