Fix change password functionality about macc HOT 13 CLOSED

i think this can be a good code in task

from macc.

added this as a task

from macc.

https://github.com/peacecorps/app-web-server/search?utf8=%E2%9C%93&q=Confirm+password

from macc.

using abov link (basically a search you can find where to make this change ) ..its basically in 2 files .. when you setup the password or change the password

from macc.

Hi,

I am more inclined to have a text change listner on each text boxes and disable the button until both are equal to each other.

Or do you want to validate once the button is clicked? Which would be better?

Regards

P.S. I am working on this task through google code in

from macc.

@ishanqut where is the Pull request ?

from macc.

@Neetuj I see that the task is still open on the code in website. My pull request is at #32.

from macc.

I approved the task .. can you double check ?

On Fri, Dec 18, 2015 at 4:11 PM, ahmedsabie [email protected]
wrote:

@Neetuj https://github.com/Neetuj I see that the task is still open on
the code in website. My pull request is at #32
#32.

—
Reply to this email directly or view it on GitHub
#11 (comment)
.

from macc.

@Neetuj I didn't claim the task yet because my current task is still being reviewed. Can I claim it after?

from macc.

Hi

sorry I am not sure which task you are talking about
if its this one ..
Task instance for Ishan Joshi PCHB-Fix change password functionality
(Systers, an Anita Borg Institute Community)

then this was already claimed by Ishan

sorry for the confusion .. but if you are working on another task then this
is the sequence of events

1. claim

2. consult

3. make the change

4. PR

5. approve

On Fri, Dec 18, 2015 at 4:33 PM, ahmedsabie [email protected]
wrote:

@Neetuj https://github.com/Neetuj I didn't claim the task yet because
my current task is still being reviewed. Can I claim it after?

—
Reply to this email directly or view it on GitHub
#11 (comment)
.

from macc.

oh yeah I am referring to this task, but I still see it on the Google Code in website. I didn't claim it because I am doing another task which is being reviewed, so I thought I would make the pull request first. What should I do?

from macc.

This is already done by ishan and approved

Sent from my iPhone

On Dec 18, 2015, at 4:38 PM, ahmedsabie [email protected] wrote:

oh yeah I am referring to this task, but I still see it on the Google Code in website. I didn't claim it because I am doing another task which is being reviewed, so I thought I would make the pull request first. What should I do?

—
Reply to this email directly or view it on GitHub.

from macc.

ah ok I didn't know that. Thanks for letting me know.

from macc.