Giter VIP home page Giter VIP logo

Comments (7)

szmarczak avatar szmarczak commented on May 28, 2024 1

You can't.

from cacheable-lookup.

sindresorhus avatar sindresorhus commented on May 28, 2024 1

I think we should open an issue on Node.js then about adding an API to officially allow intercepting http.get calls. There are lots of use-cases for that, including caching, debugging, etc.

from cacheable-lookup.

szmarczak avatar szmarczak commented on May 28, 2024

If shimmer mocks the require function, then you're good. Just remember to import got after mocking http.

Anyway I don't like that approach - it's too much hassle. Why don't you use something simpler, for example Got hooks? I mean the beforeRequest hook. You can change the options too.

from cacheable-lookup.

Kikobeats avatar Kikobeats commented on May 28, 2024

My point is, how to leverage the functionality on this library into the http underlayer without using an explicit require or involve a dependency that integrates this library?

from cacheable-lookup.

sindresorhus avatar sindresorhus commented on May 28, 2024

I agree it could be useful to be able to globally inject this, as long as it's clearly documented it should not be done in reusable packages.

Something like:

const CacheableLookup = require('cacheable-lookup');

CacheableLookup.initGlobally();

Where initGlobally() would accept the same options as an instance.

from cacheable-lookup.

szmarczak avatar szmarczak commented on May 28, 2024

See nodejs/node#18795

from cacheable-lookup.

szmarczak avatar szmarczak commented on May 28, 2024

We cannot patch the http module, but we can override the global Agent.

from cacheable-lookup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.