DNS over HTTPS support about cacheable-lookup HOT 16 OPEN

One question, would we be using cloudflare or google DoH APIs for this (Ex.: https://cloudflare-dns.com/dns-query). Interested to contribute here

from cacheable-lookup.

I think the CloudFlare one is a good start to implement, then we can do something like this:

const cacheable = new CacheableLookup();

cacheable.servers = [
	  '8.8.8.8', // DNS over UDP/TCP
	  'https://1.1.1.1/dns-query', // DNS over HTTPS
];

There's a spec at https://datatracker.ietf.org/doc/html/rfc8484

I'd do this by storing HTTP/2 sessions in an object (key would be a string starting with https://). We can detect cacheable.servers changes in

so when it's updated, we close sessions that are no longer required and open new ones if there shall be. Then when a user makes a DNS request

we simply go through the list and send a HTTP/2 request to the DoH server and handle that. Note that dns.Resolver doesn't accept DoH servers so we need to filter the list before calling resolver.setServers.

It's possible that there may be multiple DoH servers. This can be quite a hassle, so no need to do this all in one PR.

from cacheable-lookup.

Thanks, would go through the specification once, DoH queries should be round robin if multiple DoH servers are given right?

from cacheable-lookup.

No, those should be fallback servers. As per Node.js docs:

Fallback DNS servers will only be used if the earlier ones time out or result in some other error.

from cacheable-lookup.

Got it, thanks

from cacheable-lookup.

I created doh-resolver to use DNS-over-HTTPS as resolver with cacheable-lookup:

const CacheableLookup = require('cacheable-lookup')
const DoHResolver = require('doh-resolver')
const https = require('https')

const resolver = new DoHResolver({ servers: ['1.1.1.1', '8.8.8.8'] })

const cacheable = new CacheableLookup({ resolver })

https.get('https://example.com', { lookup: cacheable.lookup }, response => {
  // Handle the response here
})

from cacheable-lookup.

Awesome! It's quite heavy though, can you reduce the size?

from cacheable-lookup.

yea, I'm working on it; the main dependency is dns2 that is exporting a lot of things I really don't need

from cacheable-lookup.

Are you sure?

from cacheable-lookup.

gotcha; shipped [email protected] that removes the logger dependency

from cacheable-lookup.

Awesome! Would you be up to sending a PR mentioning this in the docs?

from cacheable-lookup.

PR #77 fixes this! 🎉

See 🍊 Tangerine and forwardemail/nodejs-dns-over-https-tangerine#1.

from cacheable-lookup.

Reported as spam to GitHub

from cacheable-lookup.

Reported for spam

from cacheable-lookup.

BTW this is how I use cacheable-lookup with tangerine for getting DNS-over-HTTPs:

new CacheableLookup({
  resolver: new Tangerine(
    {
      cache: false,
    },
    require('got').extend({
      responseType: 'buffer',
      decompress: false,
      retry: 0
    })
  )
})

If this looks good to @titanism I can create a PR to add it into the README 🙂

from cacheable-lookup.

You're welcome to add whatever you like! This nicely shows how it supports things other than undici.

from cacheable-lookup.