Giter VIP home page Giter VIP logo

Comments (5)

t0xa avatar t0xa commented on July 17, 2024

Hi James,

Thanks a lot for your contribution.
I think it's reasonable PR. I'll release version shortly.

I've also added tests for your appender. Please review it.

Anton

from gelfj.

t0xa avatar t0xa commented on July 17, 2024

v1.1.15 published. Please check.

from gelfj.

the-james-burton avatar the-james-burton commented on July 17, 2024

Yes, it looks good thanks, I've caught up in my fork.

I had one extra thing to go in and that was just to log out a decent error message when it cannot parse the JSON. I will do another PR for that and update the test too.

from gelfj.

t0xa avatar t0xa commented on July 17, 2024

Thanks James, Much appreciated. Waiting for PR.

from gelfj.

the-james-burton avatar the-james-burton commented on July 17, 2024

#104

from gelfj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.