Giter VIP home page Giter VIP logo

Comments (5)

knausj85 avatar knausj85 commented on July 28, 2024

@JeongJuhyeon
Sorry for the inconvenience, the logic is now ide-specific since the regex was just too fragile across platforms/programs.

Something like this just needs to be added to the jetbrains.py - could probably just use the old regex if it works.
https://github.com/knausj85/knausj_talon/blob/master/apps/vscode/vscode.py

from community.

JeongJuhyeon avatar JeongJuhyeon commented on July 28, 2024

Okay, Ill give it a try!
Would falling back on the regex if the other method fails until we have implementations for more IDEs be too messy?

from community.

knausj85 avatar knausj85 commented on July 28, 2024

It was really just too fragile to be useful cross-platform/cross-app. We'd fix it for one platform or program, and another would break. I'd rather it do nothing for an application by default than break. It's also one reason I added support to force enable languages via commands.

You could probably get away with using the regex in the jetbrains-specific implementation. I have no objections to that, but it's probably worth doing it without the regex to make it more robust.

from community.

JeongJuhyeon avatar JeongJuhyeon commented on July 28, 2024

Fair enough 👍

from community.

splondike avatar splondike commented on July 28, 2024

Closing issue.

from community.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.