Giter VIP home page Giter VIP logo

Comments (13)

PrimulaX avatar PrimulaX commented on June 12, 2024 10

I put a fixed version of react and react-dom in resolutions for yarn and overrides for npm

"resolutions": {
    "react": "18.2.0",
    "react-dom": "18.2.0",
  },

from tamagui.

flexbox avatar flexbox commented on June 12, 2024 2

Confirmed
@PrimulaX fix worked for me thanks!

from tamagui.

ehxxn avatar ehxxn commented on June 12, 2024 1

btw there is a fix going on for that missing dependency that might fix this one as well
try that one and let me know
it should be published today

from tamagui.

natew avatar natew commented on June 12, 2024 1

Yea so this isn't really a tamagui issue, but we need to pin react/react-dom in any parent apps. Our dependencies are defined properly.

If you have a custom project you need to make sure your react in your lockfile is resolved to a single version:

expo/expo#28471 (comment)

from tamagui.

ehxxn avatar ehxxn commented on June 12, 2024

Unfortunately, I wasn't able to re-reproduce! it seems to be working for me

from tamagui.

milos201 avatar milos201 commented on June 12, 2024

Unfortunately, I wasn't able to re-reproduce! it seems to be working for me

Did you try android production build?

This is the command used to build:

npx react-native bundle --platform android --dev false --entry-file ./index.js --bundle-output ./android/app/src/main/assets/index.android.bundle --assets-dest ./android/app/src/main/res
cd ./android
./gradlew assembleRelease

from tamagui.

arekkubaczkowski avatar arekkubaczkowski commented on June 12, 2024

#2588 (comment)

from tamagui.

natew avatar natew commented on June 12, 2024

@TheEhsanSarshar can you add to your up next to check our starters (takeout + free) and just be sure they aren't running into this, we may need to use resolutions for now to make sure we get the 18.2

from tamagui.

ehxxn avatar ehxxn commented on June 12, 2024

Tested, Expo router starter, Free - starter, Takeout ( on master branch )
everything seems fine, I don't see that error

I build the project locally using npx expo run:android --variant release

from tamagui.

milos201 avatar milos201 commented on June 12, 2024

I don't use expo. I added build command here. And build finishes with no problem. An error occurs on application start up (android prod).

from tamagui.

ehxxn avatar ehxxn commented on June 12, 2024

builts shouldn't differ between expo and cli.
have you tried solutions posted here ?expo/expo#28471 (comment)

from tamagui.

milos201 avatar milos201 commented on June 12, 2024

I already use yarn.

yarn why v1.22.22
[1/4] 🤔  Why do we have the module "react-dom"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "tamagui#@tamagui#select" depends on it
   - Hoisted from "tamagui#@tamagui#select#react-dom"
   - Hoisted from "@tamagui#config#@tamagui#web#react-dom"
   - Hoisted from "tamagui#@tamagui#popover#@tamagui#floating#react-dom"
info Disk size without dependencies: "4.94MB"
info Disk size with unique dependencies: "5.16MB"
info Disk size with transitive dependencies: "5.19MB"
info Number of shared dependencies: 3
✨  Done in 0.24s.

from tamagui.

lopugit avatar lopugit commented on June 12, 2024

Hey thanks yeah hardcoding the versions fixed this 🙏

from tamagui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.