Giter VIP home page Giter VIP logo

Comments (9)

realgs avatar realgs commented on July 20, 2024 2

It is because .remove() function is not supported by IE.
You can use jquery or augmenting native DOM functions instead.
@tameemsafi I can take a look at this issue if you want me to.

from typewriterjs.

sebastianjung avatar sebastianjung commented on July 20, 2024 2

For me the problem (or some other?) still exists. When using .deleteChars(x) IE11 gives me the following error:
"Uncaught Type: Cannot Read Property RemoveChild of Null"

This problem does not exist in version 2.5.0 but does in 2.5.1 and 2.5.2. Hope this helps.

from typewriterjs.

tameemsafi avatar tameemsafi commented on July 20, 2024

@realgs that would be great if you can do that and make a pull request

from typewriterjs.

dtslvr avatar dtslvr commented on July 20, 2024

It is because .remove() function is not supported by IE.

Yes, that's it. I could fix it in my project by adding the dom4 polyfill.

from typewriterjs.

tameemsafi avatar tameemsafi commented on July 20, 2024

You can also import from corejs library.
https://github.com/zloirock/core-js/blob/master/README.md

from typewriterjs.

realgs avatar realgs commented on July 20, 2024

I wanted to test my solution before PR, how do you run your project? There are no instructions in readme.md. Which local server do you use?

I tried building the project with yarn run build:dev and then running live-server on chained-example but there's a 404 error on dist/core.js file. From google I can suppose it might be related to Grunt. If I manually copy the dist/core.js file to examples/chained-example/ and link it adequately everything works fine.

from typewriterjs.

tameemsafi avatar tameemsafi commented on July 20, 2024

@realgs You need to use some sort of server. I would recommend http-server on npm and then run that command on the main repo directory locally. That way you will have access to localhost:8080/examples folder.

Also I fixed the issue now in v2.5.0. I just imported a polyfill for node.remove.

from typewriterjs.

sebastianjung avatar sebastianjung commented on July 20, 2024

I am also facing the problem, that too many characters are deleted when using .deleteChars() in the second loop run.

See here dev.pds.ultrabold.de. it runs 4 sentences but when running the second time it deletes the whole sentence instead of just a few words (as expected).

from typewriterjs.

danielhaim1 avatar danielhaim1 commented on July 20, 2024

I also tested deleteChars(#) as well as adding DOM4 to polyfill. Unfortunately neither methods worked for me and the bug still occurs for IE11.

from typewriterjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.