Comments (5)
tannerlinsley
commented on May 4, 2024
I think what happens Is that when a query is fetched (regardless) of cause, the error is set to null. This may not be right.
https://github.com/tannerlinsley/react-query/blob/master/src/index.js#L258
Tanner Linsley
…On Dec 6, 2019, 3:44 AM -0700, Andrew Cherniavskii ***@***.***>, wrote:
HI,
I've used react-query for polling request and noticed weird behavior.
Expect behavior:
When request fails, query.error shouldn't be reset null until request succeed.
Current behavior:
When request fails, query.error value is constantly switching between null and request error value
Steps to reproduce:
• open https://codesandbox.io/s/nostalgic-swirles-q4unq
• see console output
I will debug it and keep this issue updated if I'll get more info
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
from query.
cherniavskii
commented on May 4, 2024
Yes, indeed.
I'll submit a PR.
BTW, looks like the source code in the repo is outdated comparing to NPM releases.
Can you update it?
Also, it would be great if you update Github Releases as well - this way users can subscribe to new releases and be notified when new release is out!
Let me know if I can help with something!
from query.
cherniavskii
commented on May 4, 2024
Not sure if you noticed my previous comment, so adding mention @tannerlinsley
#64 (comment)
from query.
tannerlinsley
commented on May 4, 2024
Yep. I’m away from my computer right now. I’ll update and release soon
from query.
cherniavskii
commented on May 4, 2024
@tannerlinsley Thanks!
from query.
Related Issues (20)
- Mutation is not triggered when there is an optimistic update HOT 1
- Mutation cache, old mutations gets updated key and meta on state updates
- `useQueries` results are not stable even with memorization attempts HOT 9
- Unable to type the `useMutationState` hook HOT 1
- [svelte-query] derived `$page.params` store will becomes undefined during client side navigation HOT 2
- Homepage is erroring HOT 3
- eslint-plugin-query: exhaustive-deps error not triggered when dependency is nested inside then/catch HOT 1
- Vue.js example in the docs doesn't work HOT 2
- Devtools client prop is not working on Astro
- The object passed to the `queryFn` should be typed as `QueryFunctionContext` when using `useQueries` HOT 3
- Prefetched queries in SvelteKit that uses TRPC are refetched on the client regardless of staleness
- Cancelling query retry on observer unsubscribe inconsistency HOT 2
- useInfiniteQuery causes NotifyEventQueryObserverOptionsUpdated event to be fired without query set
- different behavior without/with developer console HOT 3
- react query 3.39.3 devtools error HOT 1
- Error Boundary Error: A component suspended HOT 1
- The query gets stuck at `fetching` status when re-fetched data has cycles HOT 4
- Devtools + async persistence + custom queryKeyHashFn doesn't work HOT 14
- Solid Query: App crashes when a query in a component is resolved before a query in a context provider HOT 2
- 'PersistQueryClientProvider' refers to a value, but is being used as a type here. Did you mean 'typeof PersistQueryClientProvider' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from query.