Describe the bug We want to offer comfort hooks to query and inval

thanks for the reproduction. it really seems to be a bug around <code class="notransla

we have tests for this, so please show a reproduction: <div clas

Here's a reproduction: <a href="https://stackblitz.com/edit/vitejs-vite-hutlfq?file=sr

exhaustive-deps doesn't understand function call for query key about query HOT 4 CLOSED

fdw commented on June 19, 2024

exhaustive-deps doesn't understand function call for query key

from query.

Comments (4)

TkDodo commented on June 19, 2024 1

thanks for the reproduction. it really seems to be a bug around ??.

This yields no lint error:

queryKey: `blah${id}`,

but this does:

queryKey: `blah${id ?? -1}`,

@Newbie012 could you have a look at this?

from query.

TkDodo commented on June 19, 2024

we have tests for this, so please show a reproduction:

query/packages/eslint-plugin-query/src/__tests__/exhaustive-deps.test.ts

Lines 142 to 156 in 7b7cc2f

 { 

 name: 'should not fail when queryKey is a queryKeyFactory while having a dep as first arg', 

 code: normalizeIndent` 

  const fooQueryKeyFactory = { 

  foo: () => ['foo'] as const, 

  num: (num: number) => [...fooQueryKeyFactory.foo(), num] as const, 

  } 

  const useFoo = (num: number) => 

  useQuery({ 

  queryKey: fooQueryKeyFactory.foo(num), 

  queryFn: () => Promise.resolve(num), 

  }) 

  `, 

 },

from query.

fdw commented on June 19, 2024

Here's a reproduction: https://stackblitz.com/edit/vitejs-vite-hutlfq?file=src%2Fhooks.ts
The issue seems to be more subtly about undefined and coalescing. Maybe you have a better idea how to solve this :)

from query.

fdw commented on June 19, 2024

That was quick! Thank you very much!

from query.

exhaustive-deps doesn't understand function call for query key about query HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	{
	name: 'should not fail when queryKey is a queryKeyFactory while having a dep as first arg',
	code: normalizeIndent`
	const fooQueryKeyFactory = {
	foo: () => ['foo'] as const,
	num: (num: number) => [...fooQueryKeyFactory.foo(), num] as const,
	}

	const useFoo = (num: number) =>
	useQuery({
	queryKey: fooQueryKeyFactory.foo(num),
	queryFn: () => Promise.resolve(num),
	})
	`,
	},