String replace in a lua script via car/lua may cause incorrect substitution with multiple keys about carmine HOT 4 CLOSED

Hi Alex, thanks for the report! Have just pushed v2.1.1 to address this. Cheers :-)

from carmine.

Upgraded and tested. Still causes a problem in the case of multiple key-vars and multiple arg-vars if any key-vars contain any of the arg-vars key name.

(with-pipeline* (car/lua "if redis.call('hget', _:foo-key, _:foo) then redis.call('hget', _:bar-key, _:bar) end" {:foo-key "foo" :bar-key "bar"} {:foo "f" :bar "b"}))

> Exception ERR Error running script (call to f_208d54df12151899d96ab2931a263c0bd5fa669f): user_script:1: Script attempted to access unexisting global variable 'key'   taoensso.carmine.protocol/get-basic-reply (protocol.clj:123)

from carmine.

Sorry, seems my regex was no good for hyphenated vars. Just pushed v2.1.2 which should do the job (have tested against your example here).

Just shout if you run into any other problems.

from carmine.

Looks good thank you!

from carmine.