Giter VIP home page Giter VIP logo

Comments (5)

knazarov avatar knazarov commented on August 11, 2024 3

Having to do all the boilerplate you list is a problem. But I see a better solution from what you propose.

I think client libraries should call "crud.x" directly, without any wrappers. For this to work, the crud module should register itself in a global variable with the same name as the module name when first loaded. Then it will be possible to call "crud.x" directly.

from crud.

akudiyar avatar akudiyar commented on August 11, 2024 1

This issue may be closed, all changes are implemented.

from crud.

akudiyar avatar akudiyar commented on August 11, 2024

@knazarov I will accept either of these solutions, but exposing the whole module seems to be less safe than a list of proxy functions.

from crud.

knazarov avatar knazarov commented on August 11, 2024

@akudiyar exposing the crud functions as a global variable is not enough for the client to be able to call them. The client should still have permissions to call those functions. And those permissions must either be explicitly granted, or the user should have execute permission on the universe.

If you need granular access control, this is not something I will expose through the data access API. Instead, I propose to add full RBAC to the enterprise edition of this module. The data access API itself should not care whether you have RBAC or not. It should be an implementation detail.

Of course, users are free to roll out their own access control if they want to. For this, they would need to wrap functions as you propose.

from crud.

Totktonada avatar Totktonada commented on August 11, 2024

@akudiyar Is there anything else on the topic you want to be implemented aside of PR #58 (released in crud 0.3.0)?

from crud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.