Why not simply set the placeholder in "userland" ? about autocomplete.js HOT 5 CLOSED

Good point, actually what's special about it is that placeholder renders after autoComplete.js engine fires up and data gets loaded, and if you checked the demo I used that to have a preloading placeholder and after the data fully loads the new placeholder overwrites it which acts as an indicator that autoComplete.js is ready to be used or not incase of any error.

Still developers could still set the placeholder in their html as you mentioned or even by js by bypassing the placeholder config because it's not required.

from autocomplete.js.

Actually the way it stands the js placeholder code overwrites any placeholder set in the html even if you don't use the setting. I think it's best to just remove it as it's unnecessary.

from autocomplete.js.

That's true just checked and it does overwrite any placeholder which is not proper, I will fix it in order not to do so.

autoComplete.js is a "Use Case Design Driven" so every function has a use case and a reason behind it, that's why I have to find a good reason or more common use case to remove it. I understand that you find it necessary but others might do, fixing it will allow you to just neglect it without worrying about it.

from autocomplete.js.

@TarekRaafat I think it's best to keep a design minimal, personally. Since placeholder is just one of many attributes of a text input, why stop there? Why not add settings for maxlength, required etc. ? Since the attribute is just a 1:1 mapping, I think it's best not to include it at all. Actually, having it confused me because I was unsure whether my placeholder set in the html would still work (and it will likely confuse others).

Since calling ele.placeholder has exactly the same effect (even working the same way internally). There should be no use case that is not covered by doing the placeholder outside of it.

FWIW, this popular existing library doesn't include placeholder either: https://goodies.pixabay.com/javascript/auto-complete/demo.html

from autocomplete.js.

@mikob check v2.1.0 just released and it has fixed the placeholder overwriting bug.
You have a valid point about removing the placeholder, will consider it.

from autocomplete.js.