Giter VIP home page Giter VIP logo

Comments (9)

tareq1988 avatar tareq1988 commented on June 25, 2024

Do you have any solutions in mind?

from wordpress-settings-api-class.

GlennM avatar GlennM commented on June 25, 2024

Maybe a solution would be to include another callback type in the class which just renders text/HTML without displaying an option. Then you can add the appropriate callback to an array element in the get_settings_fields() function.

from wordpress-settings-api-class.

herewithme avatar herewithme commented on June 25, 2024

It seems to me that this is already possible with the "html" field, right?
My version supports it anyway:
https://github.com/herewithme/wordpress-settings-api-class

from wordpress-settings-api-class.

tareq1988 avatar tareq1988 commented on June 25, 2024

@herewithme your modifications looks impressive, the only thing I didn't like is tabs. I prefer tabs, because it doesn't need a page load. Other than that, it would be good for a pull request.

from wordpress-settings-api-class.

herewithme avatar herewithme commented on June 25, 2024

I agree, the tabs is typically practiced.

But in the implementation you propose each tab has its own "submit" button which is against productive because each form contained in the tabs is truly independent.

In fact, it loses the user saves the contents of a single form, and not all the tabs.

from wordpress-settings-api-class.

tareq1988 avatar tareq1988 commented on June 25, 2024

Yeah I understand the concern, but as every tab has it's own submit button,
that makes sense though.

from wordpress-settings-api-class.

herewithme avatar herewithme commented on June 25, 2024

I do not share your opinion.

I myself was convinced that the "save" button saved the data from all tabs, not just the current tab.

from wordpress-settings-api-class.

jesselawson avatar jesselawson commented on June 25, 2024

I have a fork of this project that I'm creating a wrapper for. The save button saves all data across the tabs.

from wordpress-settings-api-class.

WebDragon avatar WebDragon commented on June 25, 2024

I would like to second the opinion that there should be a single "Save" button that appears regardless of which tab is active, and saves all data across the tabs. That's just good User Interface Design doing what you would expect a well-designed interface to do.

from wordpress-settings-api-class.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.