Comments (9)
Do you have any solutions in mind?
from wordpress-settings-api-class.
Maybe a solution would be to include another callback type in the class which just renders text/HTML without displaying an option. Then you can add the appropriate callback to an array element in the get_settings_fields() function.
from wordpress-settings-api-class.
It seems to me that this is already possible with the "html" field, right?
My version supports it anyway:
https://github.com/herewithme/wordpress-settings-api-class
from wordpress-settings-api-class.
@herewithme your modifications looks impressive, the only thing I didn't like is tabs. I prefer tabs, because it doesn't need a page load. Other than that, it would be good for a pull request.
from wordpress-settings-api-class.
I agree, the tabs is typically practiced.
But in the implementation you propose each tab has its own "submit" button which is against productive because each form contained in the tabs is truly independent.
In fact, it loses the user saves the contents of a single form, and not all the tabs.
from wordpress-settings-api-class.
Yeah I understand the concern, but as every tab has it's own submit button,
that makes sense though.
from wordpress-settings-api-class.
I do not share your opinion.
I myself was convinced that the "save" button saved the data from all tabs, not just the current tab.
from wordpress-settings-api-class.
I have a fork of this project that I'm creating a wrapper for. The save button saves all data across the tabs.
from wordpress-settings-api-class.
I would like to second the opinion that there should be a single "Save" button that appears regardless of which tab is active, and saves all data across the tabs. That's just good User Interface Design doing what you would expect a well-designed interface to do.
from wordpress-settings-api-class.
Related Issues (20)
- [Tips] Creating a single col(colspan 2) subheading field HOT 3
- register_setting 3rd argument is array since 4.7.0 HOT 3
- Register subsection
- Please add feature for subsection.
- Custom Element Class
- Please change settings_sections property private to protected
- Licence your code HOT 1
- Multicheck: unable to uncheck all boxes when defaults are set HOT 3
- Save default values to the database upon activation HOT 4
- What is the get_pages() function used for? HOT 2
- Reset Options to Default HOT 1
- The procedural example does not work. HOT 2
- Release tag
- Only the active Tab fields saved, others don't HOT 2
- Feature Request: Add 'class' field attribute
- Directly Into theme
- New Release
- Number field does not rendering min, max and step attribute
- It is not working for network setting page? HOT 4
- Password field values are saved as plain-text HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wordpress-settings-api-class.